[Android] Remove --test-arguments arg from test_runner.py.

build/android/pylib/instrumentation/instrumentation_test_instance_test.py

 #!/usr/bin/env python
 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """Unit tests for instrumentation_test_instance."""
 
 # pylint: disable=protected-access
 
 import collections
@@ skipping 29 matching lines @@
       return instrumentation_test_instance.InstrumentationTestInstance(
           mock.MagicMock(), mock.MagicMock(), lambda s: None)
 
   _FlagAttributesArgs = collections.namedtuple(
       '_FlagAttributesArgs',
       [
         'command_line_flags',
         'device_flags_file',
         'strict_mode',
         'regenerate_goldens',
         'test_arguments',

[shenghuazhang, 2017/05/01 19:32:28]

I think this arg 'test_arguments' can be removed as well? Same below.

[jbudorick, 2017/05/01 19:35:53]

Done. Nice catch.

       ])
 
   def createFlagAttributesArgs(
       self, command_line_flags=None, device_flags_file=None,
       strict_mode=None, regenerate_goldens=None, test_arguments=None):

[shenghuazhang, 2017/05/01 19:32:28]

Same here.

[jbudorick, 2017/05/01 19:35:53]

Done.

     return self._FlagAttributesArgs(
         command_line_flags, device_flags_file, strict_mode,
         regenerate_goldens, test_arguments)

[shenghuazhang, 2017/05/01 19:32:28]

And here?

[jbudorick, 2017/05/01 19:35:53]

Done.

 
   def test_initializeFlagAttributes_commandLineFlags(self):
     o = self.createTestInstance()
     args = self.createFlagAttributesArgs(command_line_flags=['--foo', '--bar'])
     o._initializeFlagAttributes(args)
     self.assertEquals(o._flags, ['--enable-test-intents', '--foo', '--bar'])
 
   def test_initializeFlagAttributes_deviceFlagsFile(self):
     o = self.createTestInstance()
     with tempfile.NamedTemporaryFile() as flags_file:
@@ skipping 16 matching lines @@
     o._initializeFlagAttributes(args)
     self.assertEquals(o._flags, ['--enable-test-intents'])
 
   def test_initializeFlagAttributes_regenerateGoldens(self):
     o = self.createTestInstance()
     args = self.createFlagAttributesArgs(regenerate_goldens=True)
     o._initializeFlagAttributes(args)
     self.assertEquals(
         o._flags, ['--enable-test-intents', '--regenerate-goldens'])
 
-  def test_initializeFlagAttributes_testArgumentsRaisesException(self):
-    o = self.createTestInstance()
-    args = self.createFlagAttributesArgs(test_arguments='--foo --bar')
-    with self.assertRaises(Exception):
-      o._initializeFlagAttributes(args)
-
   def testGetTests_noFilter(self):
     o = self.createTestInstance()
     raw_tests = [
       {
         'annotations': {'Feature': {'value': ['Foo']}},
         'class': 'org.chromium.test.SampleTest',
         'superclass': 'java.lang.Object',
         'methods': [
           {
             'annotations': {'SmallTest': None},
@@ skipping 609 matching lines @@
       }),
     ]
     results = instrumentation_test_instance.GenerateTestResults(
         None, None, statuses, 0, 1000)
     self.assertEqual(1, len(results))
     self.assertEqual(base_test_result.ResultType.SKIP, results[0].GetType())
 
 
 if __name__ == '__main__':
   unittest.main(verbosity=2)