build/android/pylib/instrumentation/instrumentation_test_instance.py - Issue 2855483003: [Android] Remove --test-arguments arg from test_runner.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/android/pylib/instrumentation/instrumentation_test_instance.py

Issue 2855483003: [Android] Remove --test-arguments arg from test_runner.py. (Closed)

Patch Set: trivial rebase Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « build/android/pylib/gtest/gtest_test_instance.py ('k') | build/android/pylib/instrumentation/instrumentation_test_instance_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: build/android/pylib/instrumentation/instrumentation_test_instance.py

diff --git a/build/android/pylib/instrumentation/instrumentation_test_instance.py b/build/android/pylib/instrumentation/instrumentation_test_instance.py

index 2324fca1194d3efc8ad608b40abd5fc68e5ce898..adf36d29a41c038b0a781e00495fa0658883b1e6 100644

--- a/build/android/pylib/instrumentation/instrumentation_test_instance.py

+++ b/build/android/pylib/instrumentation/instrumentation_test_instance.py

@@ -654,13 +654,6 @@ class InstrumentationTestInstance(test_instance.TestInstance):

if args.regenerate_goldens:

self._flags.append('--regenerate-goldens')

- if args.test_arguments:

- # --test-arguments is deprecated for gtests and is in the process of

- # being removed.

- raise Exception(

- '--test-arguments is not supported for instrumentation '

- 'tests. Pass command-line flags directly instead.')

def _initializeDriverAttributes(self):

self._driver_apk = os.path.join(

constants.GetOutDirectory(), constants.SDK_BUILD_APKS_DIR,