Avoid sending mixed-content requests for ImageSet contexts

Avoid sending mixed-content requests for ImageSet contexts

ImageSet context resources, namely <picture> and srcset based images,
are blockable mixed-content, yet we were sending out such requests, even
if not displaying them, due to the preloadScanner ignoring the difference
between them and `<img src>` based images

This CL fixes that, by blocking such images.

BUG=713440
Review-Url: https://codereview.chromium.org/2855163002
Cr-Commit-Position: refs/heads/master@{#469314}
Committed: https://chromium.googlesource.com/chromium/src/+/babb7e6d7db134dab30bfa1419fc0b45744a2645

[Yoav Weiss, 2017-05-03 15:09:11]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 15:09:34]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-05-03 15:13:26]

yoav@yoav.ws changed reviewers:
+ estark@chromium.org, mkwst@chromium.org

[Yoav Weiss, 2017-05-03 15:13:27]

Hey,

Could you kind folks take a look? I'm not happy with the test coverage just yet,
as I think a layout test is in order, but not sure what's the right place to put
it. Should I be extending the (somewhat complex) WPT tests, add a new one, or
just add a non-upstreamed LayoutTest?

Let me know what you think!

[commit-bot: I haz the power, 2017-05-03 15:52:21]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 15:52:21]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yoav Weiss, 2017-05-03 20:18:14]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-05-03 20:19:14]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-03 21:14:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-03 21:14:17]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Mike West, 2017-05-04 06:38:45]

This looks like a reasonable approach, thanks for addressing the problem! That
said, the CHECK that's triggering is something you'll need to address. Perhaps
when adding tests you can make sure you don't hit that condition?

I'm fine with this as a stand-alone WPT in the mixed-content/ directory. The
structure for those tests is a little complicated, and it shouldn't be on you to
figure out how to add things.

[Yoav Weiss, 2017-05-04 08:34:19]

On 2017/05/04 06:38:45, Mike West wrote:
> This looks like a reasonable approach, thanks for addressing the problem! That
> said, the CHECK that's triggering is something you'll need to address. Perhaps
> when adding tests you can make sure you don't hit that condition?

Yeah, my check condition was off. I'll make sure the WPT test exercises that
code.

> 
> I'm fine with this as a stand-alone WPT in the mixed-content/ directory. The
> structure for those tests is a little complicated, and it shouldn't be on you
to
> figure out how to add things.

Sounds good! :)

[Yoav Weiss, 2017-05-04 10:07:32]

The CQ bit was checked by yoav@yoav.ws to run a CQ dry run

[commit-bot: I haz the power, 2017-05-04 10:07:38]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Yoav Weiss, 2017-05-04 10:10:04]

On 2017/05/04 08:34:19, Yoav Weiss wrote:
> On 2017/05/04 06:38:45, Mike West wrote:
> > This looks like a reasonable approach, thanks for addressing the problem!
That
> > said, the CHECK that's triggering is something you'll need to address.
Perhaps
> > when adding tests you can make sure you don't hit that condition?
> 
> Yeah, my check condition was off. I'll make sure the WPT test exercises that
> code.
> 
> > 
> > I'm fine with this as a stand-alone WPT in the mixed-content/ directory. The
> > structure for those tests is a little complicated, and it shouldn't be on
you
> to
> > figure out how to add things.
> 
> Sounds good! :)

Fixed the check and added a test. PTAL

[Mike West, 2017-05-04 10:57:02]

LGTM if the bots are happy. Thanks!

[commit-bot: I haz the power, 2017-05-04 11:39:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-04 11:39:14]

Dry run: This issue passed the CQ dry run.

[Yoav Weiss, 2017-05-04 12:04:15]

The CQ bit was checked by yoav@yoav.ws

[commit-bot: I haz the power, 2017-05-04 12:04:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-04 12:10:02]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493899455815170,
"parent_rev": "0197d1982c7b408050b03cd37882ea2209d45986", "commit_rev":
"babb7e6d7db134dab30bfa1419fc0b45744a2645"}

[commit-bot: I haz the power, 2017-05-04 12:10:10]

Description was changed from

==========
Avoid sending mixed-content requests for ImageSet contexts

ImageSet context resources, namely <picture> and srcset based images,
are blockable mixed-content, yet we were sending out such requests, even
if not displaying them, due to the preloadScanner ignoring the difference
between them and `<img src>` based images

This CL fixes that, by blocking such images.

BUG=713440
==========

to

==========
Avoid sending mixed-content requests for ImageSet contexts

ImageSet context resources, namely <picture> and srcset based images,
are blockable mixed-content, yet we were sending out such requests, even
if not displaying them, due to the preloadScanner ignoring the difference
between them and `<img src>` based images

This CL fixes that, by blocking such images.

BUG=713440

Review-Url: https://codereview.chromium.org/2855163002
Cr-Commit-Position: refs/heads/master@{#469314}
Committed:
https://chromium.googlesource.com/chromium/src/+/babb7e6d7db134dab30bfa1419fc...
==========

[commit-bot: I haz the power, 2017-05-04 12:10:11]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/babb7e6d7db134dab30bfa1419fc...