third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp - Issue 2855163002: Avoid sending mixed-content requests for ImageSet contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

Issue 2855163002: Avoid sending mixed-content requests for ImageSet contexts (Closed)

Patch Set: Better check and a test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/parser/HTMLPreloadScannerTest.cpp ('k') | third_party/WebKit/Source/core/html/parser/PreloadRequest.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

index c2fdf16735b49ebc21246881611fb3c694d5b3a4..3ac547561b1131907d63bb8beb3daf85dd74af6b 100644

--- a/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

+++ b/third_party/WebKit/Source/core/html/parser/HTMLResourcePreloaderTest.cpp

@@ -53,8 +53,8 @@ class HTMLResourcePreloaderTest : public testing::Test {

String(), TextPosition(), test_case.url,

KURL(ParsedURLStringTag(), test_case.base_url), Resource::kImage,

ReferrerPolicy(), PreloadRequest::kDocumentIsReferrer,

- FetchParameters::ResourceWidth(), ClientHintsPreferences(),

- PreloadRequest::kRequestTypePreconnect);

+ ResourceFetcher::kImageNotImageSet, FetchParameters::ResourceWidth(),

+ ClientHintsPreferences(), PreloadRequest::kRequestTypePreconnect);

DCHECK(preload_request);

if (test_case.is_cors)

preload_request->SetCrossOrigin(kCrossOriginAttributeAnonymous);