third_party/WebKit/Source/core/loader/LinkLoader.cpp - Issue 2855163002: Avoid sending mixed-content requests for ImageSet contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/loader/LinkLoader.cpp

Issue 2855163002: Avoid sending mixed-content requests for ImageSet contexts (Closed)

Patch Set: Better check and a test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/loader/LinkLoader.cpp

diff --git a/third_party/WebKit/Source/core/loader/LinkLoader.cpp b/third_party/WebKit/Source/core/loader/LinkLoader.cpp

index 867e8fae1f1392bfb7259471d58ed4c4887da3e7..7138b8f7aa2bc5c38d0bc879f1d276909f2d5a3e 100644

--- a/third_party/WebKit/Source/core/loader/LinkLoader.cpp

+++ b/third_party/WebKit/Source/core/loader/LinkLoader.cpp

@@ -325,8 +325,8 @@ static Resource* PreloadIfNeeded(const LinkRelAttribute& rel_attribute,

return nullptr;

}

ResourceRequest resource_request(document.CompleteURL(href));

- resource_request.SetRequestContext(

- ResourceFetcher::DetermineRequestContext(resource_type.value(), false));

+ resource_request.SetRequestContext(ResourceFetcher::DetermineRequestContext(

+ resource_type.value(), ResourceFetcher::kImageNotImageSet, false));

if (referrer_policy != kReferrerPolicyDefault) {

resource_request.SetHTTPReferrer(SecurityPolicy::GenerateReferrer(