third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp - Issue 2855163002: Avoid sending mixed-content requests for ImageSet contexts

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp

Issue 2855163002: Avoid sending mixed-content requests for ImageSet contexts (Closed)

Patch Set: Better check and a test Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp

diff --git a/third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp b/third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp

index 939bbc147dac4a405566fca980ec4bfa70f64c1d..fa7d2f4e14d0bce8478619761cbb7ed07540ae22 100644

--- a/third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp

+++ b/third_party/WebKit/Source/core/html/parser/PreloadRequest.cpp

@@ -45,8 +45,8 @@ Resource* PreloadRequest::Start(Document* document) {

referrer_source_ == kBaseUrlIsReferrer

? base_url_.StrippedForUseAsReferrer()

: document->OutgoingReferrer()));

- resource_request.SetRequestContext(

- ResourceFetcher::DetermineRequestContext(resource_type_, false));

+ resource_request.SetRequestContext(ResourceFetcher::DetermineRequestContext(

+ resource_type_, is_image_set_, false));

if (resource_type_ == Resource::kScript)

MaybeDisallowFetchForDocWrittenScript(resource_request, defer_, *document);