Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 2854063002: [heap] Refactor updating of marking deque after scavenge. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Refactor updating of marking deque after scavenge. This introduces MarkingDeque::Update function that accepts a callback and updates marking deque elements using the callback. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2854063002 Cr-Commit-Position: refs/heads/master@{#45032} Committed: https://chromium.googlesource.com/v8/v8/+/fc6e0678d8c84ad1bf276f5424034fb9ce74f79f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -35 lines) Patch
M src/heap/incremental-marking.cc View 1 chunk +22 lines, -31 lines 0 comments Download
M src/heap/sequential-marking-deque.h View 1 chunk +19 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (5 generated)
ulan
ptal
3 years, 7 months ago (2017-05-02 11:55:55 UTC) #2
Michael Lippautz
lgtm
3 years, 7 months ago (2017-05-02 12:04:00 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2854063002/1
3 years, 7 months ago (2017-05-02 13:07:38 UTC) #6
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 13:40:23 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fc6e0678d8c84ad1bf276f5424034fb9ce7...

Powered by Google App Engine
This is Rietveld 408576698