Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 2852953004: [heap] Extract marking deque to separate file. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Extract marking deque to separate file. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2852953004 Cr-Commit-Position: refs/heads/master@{#45030} Committed: https://chromium.googlesource.com/v8/v8/+/41af9bc51b74847d714bfe2520f1273eb63fbcf8

Patch Set 1 #

Patch Set 2 : fix build.gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+268 lines, -226 lines) Patch
M BUILD.gn View 1 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/mark-compact.h View 3 chunks +3 lines, -142 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +0 lines, -84 lines 0 comments Download
A src/heap/sequential-marking-deque.h View 1 chunk +163 lines, -0 lines 0 comments Download
A src/heap/sequential-marking-deque.cc View 1 chunk +98 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 8 (4 generated)
ulan
PTAL.
3 years, 7 months ago (2017-05-02 11:38:05 UTC) #2
Michael Lippautz
lgtm
3 years, 7 months ago (2017-05-02 11:38:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852953004/20001
3 years, 7 months ago (2017-05-02 11:39:02 UTC) #5
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 12:48:14 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/v8/v8/+/41af9bc51b74847d714bfe2520f1273eb63...

Powered by Google App Engine
This is Rietveld 408576698