Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2850373003: [heap] Fix computation of marking progress in incremental finalization. (Closed)

Created:
3 years, 7 months ago by ulan
Modified:
3 years, 7 months ago
Reviewers:
Michael Lippautz
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office)
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

[heap] Fix computation of marking progress in incremental finalization. The existing formula returns non-sense when the old top is greater than the current top. BUG=chromium:694255 Review-Url: https://codereview.chromium.org/2850373003 Cr-Commit-Position: refs/heads/master@{#45037} Committed: https://chromium.googlesource.com/v8/v8/+/5a766b4401b262aa7dcf9e32e37157ddb8a07b28

Patch Set 1 #

Patch Set 2 : add comment #

Patch Set 3 : rearrange summands #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M src/heap/incremental-marking.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M src/heap/sequential-marking-deque.h View 1 2 2 chunks +5 lines, -2 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 11 (7 generated)
ulan
ptal
3 years, 7 months ago (2017-05-02 12:15:57 UTC) #5
Michael Lippautz
lgtm
3 years, 7 months ago (2017-05-02 12:23:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2850373003/40001
3 years, 7 months ago (2017-05-02 13:51:32 UTC) #8
commit-bot: I haz the power
3 years, 7 months ago (2017-05-02 14:28:18 UTC) #11
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/5a766b4401b262aa7dcf9e32e37157ddb8a...

Powered by Google App Engine
This is Rietveld 408576698