[Android] Fix direct share in context menu does not close dialog when clicked

[Android] Fix direct share in context menu does not close dialog when clicked

After the direct share icon is clicked, the dialog of context menu
does not dissmiss. This is because onClick event of the direct share
icon does not call dialog to dismiss. To fix the problem, add an
delegate interface for direct share action and implement it in the
TabularContextMenuUi.

BUG=None

Review-Url: https://codereview.chromium.org/2853483003
Cr-Commit-Position: refs/heads/master@{#468454}
Committed: https://chromium.googlesource.com/chromium/src/+/174d25a6b6a60a68090facf740178025c6eeebfb

[ltian, 2017-04-28 23:08:12]

ltian@chromium.org changed reviewers:
+ tedchoc@chromium.org

[ltian, 2017-04-28 23:08:12]

Could you take a look of the changes in this CL?

Thanks!

[Ted C, 2017-05-01 16:38:24]

https://codereview.chromium.org/2853483003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
(right):

https://codereview.chromium.org/2853483003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java:165:
new TabularContextMenuListAdapter(items, activity, this);
Any thoughts of just wrapping the runnable instead of creating a new interface?

mOnShareItemClicked = new Runnable() {
    @Override
    public void run() {
        onShareItemClicked.run();
        mDialog.dismiss();
    }
};

[ltian, 2017-05-01 18:57:36]

https://codereview.chromium.org/2853483003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
(right):

https://codereview.chromium.org/2853483003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java:165:
new TabularContextMenuListAdapter(items, activity, this);
On 2017/05/01 16:38:23, Ted C wrote:
> Any thoughts of just wrapping the runnable instead of creating a new
interface?
> 
> mOnShareItemClicked = new Runnable() {
>     @Override
>     public void run() {
>         onShareItemClicked.run();
>         mDialog.dismiss();
>     }
> };

That is a cleaner design for the code.

[Ted C, 2017-05-01 19:55:17]

lgtm

[ltian, 2017-05-01 21:28:02]

The CQ bit was checked by ltian@chromium.org

[commit-bot: I haz the power, 2017-05-01 21:28:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-01 22:21:18]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493674082449480,
"parent_rev": "65003efd91d69d2e4688e4b699dfb1b825683266", "commit_rev":
"174d25a6b6a60a68090facf740178025c6eeebfb"}

[commit-bot: I haz the power, 2017-05-01 22:21:31]

Description was changed from

==========
[Android] Fix direct share in context menu does not close dialog when clicked

After the direct share icon is clicked, the dialog of context menu
does not dissmiss. This is because onClick event of the direct share
icon does not call dialog to dismiss. To fix the problem, add an
delegate interface for direct share action and implement it in the
TabularContextMenuUi.

BUG=None
==========

to

==========
[Android] Fix direct share in context menu does not close dialog when clicked

After the direct share icon is clicked, the dialog of context menu
does not dissmiss. This is because onClick event of the direct share
icon does not call dialog to dismiss. To fix the problem, add an
delegate interface for direct share action and implement it in the
TabularContextMenuUi.

BUG=None

Review-Url: https://codereview.chromium.org/2853483003
Cr-Commit-Position: refs/heads/master@{#468454}
Committed:
https://chromium.googlesource.com/chromium/src/+/174d25a6b6a60a68090facf74017...
==========

[commit-bot: I haz the power, 2017-05-01 22:21:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/174d25a6b6a60a68090facf74017...