[Android] Fix context menu direct share bugs

[Android] Fix context menu direct share bugs

Ths CL contains two main issues related to the direct share in Chrome
context menu:
1. Share in context menu only supports sharing image. However, direct
share could show the option that is not supported for image sharing
because it uses the same logic with direct share on overflow menu
which supports sharing for different kind of url. To fix this, check
whether the direct share option supports image sharing, if not, hidding
the icon.
2. Sharing option choosen from context menu is not updated in the direct
share. To fix it, follow the same logic as sharing from overflow menu
which adds an intent sender to notify the update.

BUG=None

Review-Url: https://codereview.chromium.org/2855743002
Cr-Commit-Position: refs/heads/master@{#469755}
Committed: https://chromium.googlesource.com/chromium/src/+/8f6f9c1597928d3df4cd6a44942c323ef8e46fee

[ltian, 2017-05-01 21:29:19]

ltian@chromium.org changed reviewers:
+ tedchoc@chromium.org

[ltian, 2017-05-01 21:29:20]

Can you take a look of the changes in this CL?

Thanks!

[Ted C, 2017-05-04 15:05:13]

https://codereview.chromium.org/2855743002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/2855743002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:368:
TargetChosenReceiver.sendChooserIntent(
You'll need to do additional checks here as the TargetChosenReceiver is only
available in LMR1:
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

https://codereview.chromium.org/2855743002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:567:
Activity activity, boolean isImageShare) {
we should add javadoc for the new param

Instead of passing a boolean, should this pass the Intent, which seems more
extensible in the future

[ltian, 2017-05-04 21:35:39]

https://codereview.chromium.org/2855743002/diff/1/chrome/android/java/src/org...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/2855743002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:368:
TargetChosenReceiver.sendChooserIntent(
On 2017/05/04 15:05:13, Ted C wrote:
> You'll need to do additional checks here as the TargetChosenReceiver is only
> available in LMR1:
>
https://cs.chromium.org/chromium/src/chrome/android/java/src/org/chromium/chr...

Done.

https://codereview.chromium.org/2855743002/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:567:
Activity activity, boolean isImageShare) {
On 2017/05/04 15:05:13, Ted C wrote:
> we should add javadoc for the new param
> 
> Instead of passing a boolean, should this pass the Intent, which seems more
> extensible in the future

Done.

[Ted C, 2017-05-05 02:21:52]

lgtm

https://codereview.chromium.org/2855743002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/2855743002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:370:
true, activity, getShareImageIntent(imageUri), null);
We can pull out getShareImageIntent to a local var and share it between this and
the case below.  Actually, it looks like it could be shared in the outer if else
as well

https://codereview.chromium.org/2855743002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:688:
public static Intent getShareImageIntent(Uri imageUri) {
add javadoc for this now that this is public

[ltian, 2017-05-05 18:02:15]

https://codereview.chromium.org/2855743002/diff/20001/chrome/android/java/src...
File chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java
(right):

https://codereview.chromium.org/2855743002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:370:
true, activity, getShareImageIntent(imageUri), null);
On 2017/05/05 02:21:51, Ted C wrote:
> We can pull out getShareImageIntent to a local var and share it between this
and
> the case below.  Actually, it looks like it could be shared in the outer if
else
> as well

Done.

https://codereview.chromium.org/2855743002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/share/ShareHelper.java:688:
public static Intent getShareImageIntent(Uri imageUri) {
On 2017/05/05 02:21:51, Ted C wrote:
> add javadoc for this now that this is public

Done.

[ltian, 2017-05-05 18:12:32]

The CQ bit was checked by ltian@chromium.org

[ltian, 2017-05-05 18:12:33]

The patchset sent to the CQ was uploaded after l-g-t-m from tedchoc@chromium.org
Link to the patchset: https://codereview.chromium.org/2855743002/#ps40001
(title: "Update based on Ted's new comments.")

[commit-bot: I haz the power, 2017-05-05 18:13:01]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-05 19:25:13]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1494007952604500,
"parent_rev": "968d9ebc4d22158616e9f55d01313f0973d13fea", "commit_rev":
"8f6f9c1597928d3df4cd6a44942c323ef8e46fee"}

[commit-bot: I haz the power, 2017-05-05 19:25:49]

Description was changed from

==========
[Android] Fix context menu direct share bugs

Ths CL contains two main issues related to the direct share in Chrome
context menu:
1. Share in context menu only supports sharing image. However, direct
share could show the option that is not supported for image sharing
because it uses the same logic with direct share on overflow menu
which supports sharing for different kind of url. To fix this, check
whether the direct share option supports image sharing, if not, hidding
the icon.
2. Sharing option choosen from context menu is not updated in the direct
share. To fix it, follow the same logic as sharing from overflow menu
which adds an intent sender to notify the update.

BUG=None
==========

to

==========
[Android] Fix context menu direct share bugs

Ths CL contains two main issues related to the direct share in Chrome
context menu:
1. Share in context menu only supports sharing image. However, direct
share could show the option that is not supported for image sharing
because it uses the same logic with direct share on overflow menu
which supports sharing for different kind of url. To fix this, check
whether the direct share option supports image sharing, if not, hidding
the icon.
2. Sharing option choosen from context menu is not updated in the direct
share. To fix it, follow the same logic as sharing from overflow menu
which adds an intent sender to notify the update.

BUG=None

Review-Url: https://codereview.chromium.org/2855743002
Cr-Commit-Position: refs/heads/master@{#469755}
Committed:
https://chromium.googlesource.com/chromium/src/+/8f6f9c1597928d3df4cd6a44942c...
==========

[commit-bot: I haz the power, 2017-05-05 19:25:50]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/8f6f9c1597928d3df4cd6a44942c...