Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1714)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java

Issue 2853483003: [Android] Fix direct share in context menu does not close dialog when clicked (Closed)
Patch Set: Update based on Ted's comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
index ef2f4045d44f2e15830f6edfdb156473718425eb..9b6a9947d84b37e32766e2b366e4c8f45bb78ed9 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java
@@ -26,7 +26,7 @@ import java.util.List;
class TabularContextMenuListAdapter extends BaseAdapter {
private final List<ContextMenuItem> mMenuItems;
private final Activity mActivity;
- private final Runnable mOnShareItemClicked;
+ private final Runnable mOnDirectShare;
/**
* Adapter for the tabular context menu UI
@@ -34,10 +34,10 @@ class TabularContextMenuListAdapter extends BaseAdapter {
* @param activity Used to inflate the layout.
*/
TabularContextMenuListAdapter(
- List<ContextMenuItem> menuItems, Activity activity, Runnable onShareItemClicked) {
+ List<ContextMenuItem> menuItems, Activity activity, Runnable onDirectShare) {
mMenuItems = menuItems;
mActivity = activity;
- mOnShareItemClicked = onShareItemClicked;
+ mOnDirectShare = onDirectShare;
}
@Override
@@ -91,7 +91,7 @@ class TabularContextMenuListAdapter extends BaseAdapter {
viewHolder.mShareIcon.setOnClickListener(new View.OnClickListener() {
@Override
public void onClick(View view) {
- mOnShareItemClicked.run();
+ mOnDirectShare.run();
}
});
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698