Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java

Issue 2853483003: [Android] Fix direct share in context menu does not close dialog when clicked (Closed)
Patch Set: Update based on Ted's comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
index 64096dc5b90cb5c6bb85d6bd5371b7ae7bd5f1d8..66695f0a22cf3399b465fe41c73d051422fdb020 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuUi.java
@@ -160,8 +160,15 @@ public class TabularContextMenuUi implements ContextMenuUi, AdapterView.OnItemCl
}
// Set the list adapter and get the height to display it appropriately in a dialog.
+ Runnable onDirectShare = new Runnable() {
+ @Override
+ public void run() {
+ mOnShareItemClicked.run();
+ mDialog.dismiss();
+ }
+ };
TabularContextMenuListAdapter listAdapter =
- new TabularContextMenuListAdapter(items, activity, mOnShareItemClicked);
+ new TabularContextMenuListAdapter(items, activity, onDirectShare);
ViewGroup.LayoutParams layoutParams = listView.getLayoutParams();
layoutParams.height = measureApproximateListViewHeight(listView, listAdapter, maxCount);
listView.setLayoutParams(layoutParams);
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/contextmenu/TabularContextMenuListAdapter.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698