Rename KeyLock to KeyboardLock and return enum from IPC

Rename KeyLock to KeyboardLock and return enum from IPC

This change addresses one remaining work in change
https://codereview.chromium.org/2805763004/ to modify the return value of
RequestKeyLock() mojom interface from (bool, string) to an enumeration.
Meanwhile, after discussing with Gary (GaryKac@), we would prefer to keep
"Keyboard" as part of the function name. So all "KeyLock"s are changed to
"KeyboardLock".

BUG=680809
Review-Url: https://codereview.chromium.org/2852823002
Cr-Commit-Position: refs/heads/master@{#468791}
Committed: https://chromium.googlesource.com/chromium/src/+/b67deca63eb94ec8e8fef981b0581d35ed7341fe

[Hzj_jie, 2017-04-29 00:23:43]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-29 00:24:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-29 00:37:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 00:37:13]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)

[Hzj_jie, 2017-04-29 01:31:59]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[Hzj_jie, 2017-04-29 01:32:25]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-04-29 01:32:41]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Hzj_jie, 2017-04-29 01:36:01]

Description was changed from

==========
Rename KeyLock to KeyboardLock and return enum from IPC

BUG=680809
==========

to

==========
Rename KeyLock to KeyboardLock and return enum from IPC

This change addresses one remaining work in change
https://codereview.chromium.org/2805763004/ to modify the return value of
RequestKeyLock() mojom interface from (bool, string) to an enumeration.
Meanwhile, after discussing with Gary (GaryKac@), we would prefer to keep
"Keyboard" as part of the function name. So all "KeyLock"s are changed to
"KeyboardLock".

BUG=680809
==========

[commit-bot: I haz the power, 2017-04-29 03:08:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-29 03:08:39]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2017-05-01 17:51:55]

zijiehe@chromium.org changed reviewers:
+ avayvod@chromium.org, avi@chromium.org, dcheng@chromium.org,
foolip@chromium.org, haraken@chromium.org

[Hzj_jie, 2017-05-01 17:53:23]

This is a follow up change to address several of unresolved comments in
https://codereview.chromium.org/2805763004/.

As the description, it contains renaming of the JS API and the return type of
mojom interface.

[Avi (use Gerrit), 2017-05-01 18:06:48]

lgtm

stamp

[whywhat, 2017-05-02 02:02:27]

lgtm

do you intend to throw an exception with a different message based on the
failure type later on?

[haraken, 2017-05-02 04:39:59]

WebKit LGTM

[Hzj_jie, 2017-05-02 04:45:15]

On 2017/05/02 02:02:27, whywhat wrote:
> lgtm
> 
> do you intend to throw an exception with a different message based on the
> failure type later on?

Before we decide to involve permission control for this feature -- I doubt we
will never do it, Chrome does not return Failure. So
navigator.requestKeyboardLock() never fails except for parallel requests. (In
navigator-requestKeyLock-two-parallel-requests.https.html.)
But since we need to know when the execution of the API has been finished
anyway, RequestKeyboardLock() mojom API needs to have a return value.

[dcheng, 2017-05-02 07:38:16]

lgtm

https://codereview.chromium.org/2852823002/diff/20001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom
(right):

https://codereview.chromium.org/2852823002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom:9:
FAILURE = 1,  // Chrome never returns a failure.
Remove this comment, or just remove this enum value until it's used.

[Hzj_jie, 2017-05-02 17:58:47]

The CQ bit was checked by zijiehe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-05-02 17:59:19]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 19:44:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-05-02 19:44:25]

Dry run: This issue passed the CQ dry run.

[Hzj_jie, 2017-05-02 22:12:08]

https://codereview.chromium.org/2852823002/diff/20001/third_party/WebKit/publ...
File
third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom
(right):

https://codereview.chromium.org/2852823002/diff/20001/third_party/WebKit/publ...
third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom:9:
FAILURE = 1,  // Chrome never returns a failure.
On 2017/05/02 07:38:16, dcheng (OOO through May 2) wrote:
> Remove this comment, or just remove this enum value until it's used.

I prefer to remove this value of enumeration.
Done.

[Hzj_jie, 2017-05-02 22:12:13]

The CQ bit was checked by zijiehe@chromium.org

[Hzj_jie, 2017-05-02 22:12:14]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, avayvod@chromium.org, avi@chromium.org,
dcheng@chromium.org
Link to the patchset: https://codereview.chromium.org/2852823002/#ps40001
(title: "Remove KeyboardLockRequestResult::FAILURE; it is not used by Chrome.")

[commit-bot: I haz the power, 2017-05-02 22:12:56]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-05-02 22:18:44]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493763133405750,
"parent_rev": "c3efb07dd4212081ae8ad66551feba3ae21ba417", "commit_rev":
"b67deca63eb94ec8e8fef981b0581d35ed7341fe"}

[commit-bot: I haz the power, 2017-05-02 22:18:54]

Description was changed from

==========
Rename KeyLock to KeyboardLock and return enum from IPC

This change addresses one remaining work in change
https://codereview.chromium.org/2805763004/ to modify the return value of
RequestKeyLock() mojom interface from (bool, string) to an enumeration.
Meanwhile, after discussing with Gary (GaryKac@), we would prefer to keep
"Keyboard" as part of the function name. So all "KeyLock"s are changed to
"KeyboardLock".

BUG=680809
==========

to

==========
Rename KeyLock to KeyboardLock and return enum from IPC

This change addresses one remaining work in change
https://codereview.chromium.org/2805763004/ to modify the return value of
RequestKeyLock() mojom interface from (bool, string) to an enumeration.
Meanwhile, after discussing with Gary (GaryKac@), we would prefer to keep
"Keyboard" as part of the function name. So all "KeyLock"s are changed to
"KeyboardLock".

BUG=680809

Review-Url: https://codereview.chromium.org/2852823002
Cr-Commit-Position: refs/heads/master@{#468791}
Committed:
https://chromium.googlesource.com/chromium/src/+/b67deca63eb94ec8e8fef981b058...
==========

[commit-bot: I haz the power, 2017-05-02 22:18:56]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/b67deca63eb94ec8e8fef981b058...