Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1514)

Unified Diff: third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom

Issue 2852823002: Rename KeyLock to KeyboardLock and return enum from IPC (Closed)
Patch Set: Remove KeyboardLockRequestResult::FAILURE; it is not used by Chrome. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom
diff --git a/third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom b/third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom
index 81757ac24cbbbc197508862f91f973a456ad349a..ced395c922633f5516ca9f80b6e179af9b8b9f84 100644
--- a/third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom
+++ b/third_party/WebKit/public/platform/modules/keyboard_lock/keyboard_lock.mojom
@@ -4,18 +4,20 @@
module blink.mojom;
-// The browser side service to process navigator.requestKeyLock() and
-// navigator.cancelKeyLock() web APIs. See http://crbug.com/680809.
+enum KeyboardLockRequestResult {
+ SUCCESS = 0,
+};
+
+// The browser side service to process navigator.requestKeyboardLock() and
+// navigator.cancelKeyboardLock() web APIs. See http://crbug.com/680809.
interface KeyboardLockService {
// Registers a set of string-formatted key codes
// (https://www.w3.org/TR/uievents/#interface-keyboardevent) to the platform
// dependent native API, so the web page can receive these key codes
// thereafter.
- // The reason will only be provided if the request is rejected.
- // TODO(zijiehe): Update the return type once it's defined in the spec.
- RequestKeyLock(array<string> key_codes)
- => (bool allowed_by_user_or_browser, string reason);
+ RequestKeyboardLock(array<string> key_codes)
+ => (KeyboardLockRequestResult result);
// Removes all reserved keys. This function is expected to never fail.
- CancelKeyLock();
+ CancelKeyboardLock();
};
« no previous file with comments | « third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698