third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idlharness.https.html - Issue 2852823002: Rename KeyLock to KeyboardLock and return enum from IPC

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idlharness.https.html

Issue 2852823002: Rename KeyLock to KeyboardLock and return enum from IPC (Closed)

Patch Set: Remove KeyboardLockRequestResult::FAILURE; it is not used by Chrome. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/W3CImportExpectations ('k') | third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idlharness.https-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idlharness.https.html

diff --git a/third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idlharness.https.html b/third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idlharness.https.html

index 40b6a8af5cb05f00e370cf30f6dcbf64fad5c308..6fabb4117436570586032c7b20f9423e9d0a8276 100644

--- a/third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idlharness.https.html

+++ b/third_party/WebKit/LayoutTests/external/wpt/keyboard-lock/idlharness.https.html

@@ -14,7 +14,7 @@ interface Navigator {

};

</pre>

<!--

- The reason of the failure of requestKeyLock test looks like a code defect in

+ The reason of the failure of requestKeyboardLock test looks like a code defect in

idlharness.js. media-capabilities/idlharness.html is also impacted by this

issue. See https://codereview.chromium.org/2805763004/#ps620001, which

includes a potential fix.

@@ -22,8 +22,8 @@ interface Navigator {

-->

partial interface Navigator {

- [SecureContext] Promise<void> requestKeyLock(optional sequence<DOMString> keyCodes = []);

- [SecureContext] void cancelKeyLock();

+ [SecureContext] Promise<void> requestKeyboardLock(optional sequence<DOMString> keyCodes = []);

+ [SecureContext] void cancelKeyboardLock();

};

</pre>