Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Side by Side Diff: third_party/WebKit/Source/modules/keyboard_lock/NavigatorKeyboardLock.idl

Issue 2852823002: Rename KeyLock to KeyboardLock and return enum from IPC (Closed)
Patch Set: Remove KeyboardLockRequestResult::FAILURE; it is not used by Chrome. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // https://rawgit.com/w3c/keyboard-lock/gh-pages/index.html. 5 // https://rawgit.com/w3c/keyboard-lock/gh-pages/index.html.
6 // TODO(zijiehe, garykac): Update the spec to match the implementation. 6 // TODO(zijiehe, garykac): Update the spec to match the implementation.
7 // 1. "System" should be removed from both the function names: these functions 7 // 1. "System" should be removed from both the function names: these functions
8 // are not for system keys or key combinations only. 8 // are not for system keys or key combinations only.
9 // See https://github.com/w3c/keyboard-lock/issues/6 9 // See https://github.com/w3c/keyboard-lock/issues/6
10 // 2. Returns Promise<void> from requestKeyLock() function: user agents can 10 // 2. Returns Promise<void> from requestKeyboardLock() function: user agents can
11 // decline the request, and web page can get a notification once the 11 // decline the request, and web page can get a notification once the
12 // requested keys should be received. 12 // requested keys should be received.
13 // See https://github.com/w3c/keyboard-lock/issues/7 13 // See https://github.com/w3c/keyboard-lock/issues/7
14 // 3. The parameter of requestKeyLock() should be 14 // 3. The parameter of requestKeyboardLock() should be
15 // optional sequence<DOMString> keyCodes = [] 15 // optional sequence<DOMString> keyCodes = []
16 // See https://github.com/w3c/keyboard-lock/issues/21 16 // See https://github.com/w3c/keyboard-lock/issues/21
17 // 4. cancelKeyLock() function is implicitly called whenever the unloading 17 // 4. cancelKeyboardLock() function is implicitly called whenever the unloading
18 // document cleanup steps run with a document. 18 // document cleanup steps run with a document.
19 // See https://github.com/w3c/keyboard-lock/issues/22 19 // See https://github.com/w3c/keyboard-lock/issues/22
20 partial interface Navigator { 20 partial interface Navigator {
21 [SecureContext, RuntimeEnabled=KeyboardLock, CallWith=ScriptState] Promise<v oid> requestKeyLock(optional sequence<DOMString> keyCodes = []); 21 [SecureContext, RuntimeEnabled=KeyboardLock, CallWith=ScriptState] Promise<v oid> requestKeyboardLock(optional sequence<DOMString> keyCodes = []);
22 [SecureContext, RuntimeEnabled=KeyboardLock] void cancelKeyLock(); 22 [SecureContext, RuntimeEnabled=KeyboardLock] void cancelKeyboardLock();
23 }; 23 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698