Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2852473002: memory-infra: Plumb platform_private_footprint to MemoryDumpManager (Closed)

Created:
3 years, 7 months ago by hjd
Modified:
3 years, 7 months ago
CC:
chromium-reviews, danakj+watch_chromium.org, erikchen, ssid, tracing+reviews_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

memory-infra: Plumb platform_private_footprint to MemoryDumpManager BUG=707019 Review-Url: https://codereview.chromium.org/2852473002 Cr-Commit-Position: refs/heads/master@{#468941} Committed: https://chromium.googlesource.com/chromium/src/+/a28aa41324c5572e67d57c610fccd22132df3de4

Patch Set 1 #

Patch Set 2 : add mojo #

Patch Set 3 : remove log #

Messages

Total messages: 17 (10 generated)
hjd
ptal, thanks! :)
3 years, 7 months ago (2017-04-27 14:45:57 UTC) #2
Primiano Tucci (use gerrit)
lgtm, but I guess the "let's split CL into manageable size" message went a bit ...
3 years, 7 months ago (2017-04-28 15:26:28 UTC) #3
hjd
On 2017/04/28 15:26:28, Primiano Tucci wrote: > lgtm, but I guess the "let's split CL ...
3 years, 7 months ago (2017-05-02 11:39:21 UTC) #4
hjd
+mkwst ptal at services/resource_coordinator/public/* Thanks! I'm adding one more struct to the memory-infra mojo message.
3 years, 7 months ago (2017-05-03 10:42:48 UTC) #10
Mike West
struct lgtm.
3 years, 7 months ago (2017-05-03 10:45:00 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2852473002/40001
3 years, 7 months ago (2017-05-03 11:28:55 UTC) #14
commit-bot: I haz the power
3 years, 7 months ago (2017-05-03 11:33:05 UTC) #17
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/a28aa41324c5572e67d57c610fcc...

Powered by Google App Engine
This is Rietveld 408576698