Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1550)

Unified Diff: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h

Issue 2852473002: memory-infra: Plumb platform_private_footprint to MemoryDumpManager (Closed)
Patch Set: remove log Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h
diff --git a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h
index 55d916b9137ea944032107fe18838f8643b7ee2e..02a2b146f778151b8193cba5ba1c8198708538a0 100644
--- a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h
+++ b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h
@@ -7,6 +7,7 @@
#include "base/process/process_handle.h"
#include "base/trace_event/memory_dump_request_args.h"
+#include "base/trace_event/process_memory_totals.h"
#include "mojo/common/common_custom_types_struct_traits.h"
#include "services/resource_coordinator/public/cpp/memory/memory_export.h"
#include "services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom.h"
@@ -54,6 +55,40 @@ struct SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_EXPORT
};
template <>
+struct SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_EXPORT StructTraits<
+ memory_instrumentation::mojom::PlatformPrivateFootprintDataView,
+ base::trace_event::ProcessMemoryTotals::PlatformPrivateFootprint> {
+ static uint64_t phys_footprint_bytes(
+ const base::trace_event::ProcessMemoryTotals::PlatformPrivateFootprint&
+ args) {
+ return args.phys_footprint_bytes;
+ }
+ static uint64_t internal_bytes(
+ const base::trace_event::ProcessMemoryTotals::PlatformPrivateFootprint&
+ args) {
+ return args.internal_bytes;
+ }
+ static uint64_t compressed_bytes(
+ const base::trace_event::ProcessMemoryTotals::PlatformPrivateFootprint&
+ args) {
+ return args.compressed_bytes;
+ }
+ static uint64_t rss_anon_bytes(
+ const base::trace_event::ProcessMemoryTotals::PlatformPrivateFootprint&
+ args) {
+ return args.rss_anon_bytes;
+ }
+ static uint64_t vm_swap_bytes(
+ const base::trace_event::ProcessMemoryTotals::PlatformPrivateFootprint&
+ args) {
+ return args.vm_swap_bytes;
+ }
+ static bool Read(
+ memory_instrumentation::mojom::PlatformPrivateFootprintDataView input,
+ base::trace_event::ProcessMemoryTotals::PlatformPrivateFootprint* out);
+};
+
+template <>
struct SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_EXPORT
StructTraits<memory_instrumentation::mojom::ChromeMemDumpDataView,
base::trace_event::MemoryDumpCallbackResult::ChromeMemDump> {
@@ -86,6 +121,11 @@ struct SERVICES_RESOURCE_COORDINATOR_PUBLIC_CPP_MEMORY_EXPORT
const base::trace_event::MemoryDumpCallbackResult::OSMemDump& args) {
return args.resident_set_kb;
}
+ static base::trace_event::ProcessMemoryTotals::PlatformPrivateFootprint
+ platform_private_footprint(
+ const base::trace_event::MemoryDumpCallbackResult::OSMemDump& args) {
+ return args.platform_private_footprint;
+ }
static bool Read(memory_instrumentation::mojom::OSMemDumpDataView input,
base::trace_event::MemoryDumpCallbackResult::OSMemDump* out);
};

Powered by Google App Engine
This is Rietveld 408576698