Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2845813005: memory-infra: Plumb platform_private_footprint to service (Closed)

Created:
3 years, 7 months ago by hjd
Modified:
3 years, 7 months ago
CC:
chromium-reviews, chrome-grc-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, wfh+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, tracing+reviews_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

memory-infra: Plumb platform_private_footprint to service BUG=707019

Patch Set 1 #

Total comments: 1

Messages

Total messages: 4 (2 generated)
Primiano Tucci (use gerrit)
Lovely, another struct that we have to keep in sync manually in two places :) ...
3 years, 7 months ago (2017-04-28 15:32:26 UTC) #2
hjd
3 years, 7 months ago (2017-05-02 11:39:47 UTC) #3
On 2017/04/28 15:32:26, Primiano Tucci wrote:
> Lovely, another struct that we have to keep in sync manually in two places :)
(I
> know, it's now you)
> LGTM % 1 comment (you have a leftover logging).
> Although squashing the CL together with the other one might make it easier
even
> for mojo people to review
> 
>
https://codereview.chromium.org/2845813005/diff/1/components/tracing/common/p...
> File components/tracing/common/process_metrics_memory_dump_provider.cc
(right):
> 
>
https://codereview.chromium.org/2845813005/diff/1/components/tracing/common/p...
> components/tracing/common/process_metrics_memory_dump_provider.cc:674:
> LOG(ERROR) << "! setting rss " << rss_bytes;
> LOG(ERROR) <<&nbsp;"! I don't think you mean to land this line!" :P

How did you find this CL ;)

Powered by Google App Engine
This is Rietveld 408576698