Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(580)

Unified Diff: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc

Issue 2852473002: memory-infra: Plumb platform_private_footprint to MemoryDumpManager (Closed)
Patch Set: remove log Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
diff --git a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
index f0458fb8cc6eb6478309987dea249d68bfae2ec9..71ddde7a3afd7ecf4ded184121bb597473323860 100644
--- a/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
+++ b/services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.cc
@@ -5,6 +5,7 @@
#include "services/resource_coordinator/public/cpp/memory/memory_instrumentation_struct_traits.h"
#include "base/trace_event/memory_dump_request_args.h"
+#include "base/trace_event/process_memory_totals.h"
#include "mojo/common/common_custom_types_struct_traits.h"
#include "services/resource_coordinator/public/interfaces/memory/memory_instrumentation.mojom.h"
@@ -111,6 +112,21 @@ bool StructTraits<memory_instrumentation::mojom::RequestArgsDataView,
}
// static
+bool StructTraits<
+ memory_instrumentation::mojom::PlatformPrivateFootprintDataView,
+ base::trace_event::ProcessMemoryTotals::PlatformPrivateFootprint>::
+ Read(
+ memory_instrumentation::mojom::PlatformPrivateFootprintDataView input,
+ base::trace_event::ProcessMemoryTotals::PlatformPrivateFootprint* out) {
+ out->phys_footprint_bytes = input.phys_footprint_bytes();
+ out->internal_bytes = input.internal_bytes();
+ out->compressed_bytes = input.compressed_bytes();
+ out->rss_anon_bytes = input.rss_anon_bytes();
+ out->vm_swap_bytes = input.vm_swap_bytes();
+ return true;
+}
+
+// static
bool StructTraits<memory_instrumentation::mojom::ChromeMemDumpDataView,
base::trace_event::MemoryDumpCallbackResult::ChromeMemDump>::
Read(memory_instrumentation::mojom::ChromeMemDumpDataView input,
@@ -128,6 +144,8 @@ bool StructTraits<memory_instrumentation::mojom::OSMemDumpDataView,
Read(memory_instrumentation::mojom::OSMemDumpDataView input,
base::trace_event::MemoryDumpCallbackResult::OSMemDump* out) {
out->resident_set_kb = input.resident_set_kb();
+ if (!input.ReadPlatformPrivateFootprint(&out->platform_private_footprint))
+ return false;
return true;
}

Powered by Google App Engine
This is Rietveld 408576698