Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2851473007: Clean up StrictMode.allowThreadDiskReads calls. (Closed)

Created:
3 years, 7 months ago by Torne
Modified:
3 years, 7 months ago
Reviewers:
Ted C, mthiesse
CC:
chromium-reviews, zpeng+watch_chromium.org, dominickn+watch_chromium.org, awdf+watch_chromium.org, media-router+watch_chromium.org, vmpstr+watch_chromium.org, Peter Beverloo, mdjones+watch_chromium.org, donnd+watch_chromium.org, feature-media-reviews_chromium.org, feature-vr-reviews_chromium.org, lizeb+watch-custom-tabs_chromium.org, pkotwicz+watch_chromium.org, agrieve+watch_chromium.org, danakj+watch_chromium.org, mlamouri+watch-notifications_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up StrictMode.allowThreadDiskReads calls. allowThreadDiskWrites also allows reads, so it's not necessary to call both together. Remove all the redundant allowThreadDiskReads calls. BUG= Review-Url: https://codereview.chromium.org/2851473007 Cr-Commit-Position: refs/heads/master@{#468050} Committed: https://chromium.googlesource.com/chromium/src/+/043f5431fe09334664bf971c87b1c17ab4f2f9a6

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -40 lines) Patch
M base/android/java/src/org/chromium/base/PathUtils.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/LauncherShortcutActivity.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/bookmarkswidget/BookmarkWidgetService.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchQuickActionControl.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicy.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalauth/ExternalAuthUtils.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabbedModeTabPersistencePolicy.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java View 1 chunk +1 line, -2 lines 2 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappActivity.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappDirectoryManager.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/remote/CastTestBase.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/router/MediaRouterIntegrationTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/shape_detection/ShapeDetectionTest.java View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockStorageDelegate.java View 1 chunk +1 line, -2 lines 0 comments Download
M ui/android/java/src/org/chromium/ui/UiUtils.java View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Torne
3 years, 7 months ago (2017-04-28 15:50:57 UTC) #2
mthiesse
https://codereview.chromium.org/2851473007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java (left): https://codereview.chromium.org/2851473007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java#oldcode85 chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java:85: StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads(); I think we *do* need ...
3 years, 7 months ago (2017-04-28 16:04:08 UTC) #4
mthiesse
https://codereview.chromium.org/2851473007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java File chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java (left): https://codereview.chromium.org/2851473007/diff/1/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java#oldcode85 chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java:85: StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads(); Whoops disregard me, I failed ...
3 years, 7 months ago (2017-04-28 16:04:58 UTC) #5
Ted C
lgtm
3 years, 7 months ago (2017-04-28 16:40:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851473007/1
3 years, 7 months ago (2017-04-28 16:56:43 UTC) #8
mthiesse
vr_shell/ lgtm (our directory is noparented)
3 years, 7 months ago (2017-04-28 16:58:29 UTC) #9
Torne
On 2017/04/28 16:58:29, mthiesse wrote: > vr_shell/ lgtm (our directory is noparented) Hm. git cl ...
3 years, 7 months ago (2017-04-28 17:06:05 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 17:48:21 UTC) #13
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/043f5431fe09334664bf971c87b1...

Powered by Google App Engine
This is Rietveld 408576698