chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockStorageDelegate.java - Issue 2851473007: Clean up StrictMode.allowThreadDiskReads calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockStorageDelegate.java

Issue 2851473007: Clean up StrictMode.allowThreadDiskReads calls. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java ('K') | « chrome/android/javatests/src/org/chromium/chrome/browser/shape_detection/ShapeDetectionTest.java ('k') | ui/android/java/src/org/chromium/ui/UiUtils.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockStorageDelegate.java

diff --git a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockStorageDelegate.java b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockStorageDelegate.java

index 7dadd18986dcbaf3e7b2fdd2a6f4e0dc4e41fe7b..ea864aa778a0553d2b8afd57ac7fb0296d80815e 100644

--- a/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockStorageDelegate.java

+++ b/chrome/test/android/javatests/src/org/chromium/chrome/test/util/browser/tabmodel/document/MockStorageDelegate.java

@@ -52,8 +52,7 @@ public class MockStorageDelegate extends StorageDelegate {

@Override

public File getStateDirectory() {

// This is a test class, allowing StrictMode violations.

- StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();

- StrictMode.allowThreadDiskWrites();

+ StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskWrites();

try {

if (!mStateDirectory.exists() && !mStateDirectory.mkdirs()) {

Assert.fail("Failed to create state directory. Tests should fail.");