chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java - Issue 2851473007: Clean up StrictMode.allowThreadDiskReads calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

Issue 2851473007: Clean up StrictMode.allowThreadDiskReads calls. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/preferences/website/ManageSpaceActivity.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

index d432ee3f7a30b81fc26d1de8f7e15bd9ef4cf525..4d031c95f69e701443d195734557fb05c1a45df2 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/notifications/CustomNotificationBuilder.java

@@ -105,8 +105,7 @@ public class CustomNotificationBuilder extends NotificationBuilderBase {

String formattedTime = "";

// Temporarily allowing disk access. TODO: Fix. See http://crbug.com/577185

- StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();

- StrictMode.allowThreadDiskWrites();

+ StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskWrites();

try {

long time = SystemClock.elapsedRealtime();

formattedTime = DateFormat.getTimeFormat(mContext).format(new Date());