chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java - Issue 2851473007: Clean up StrictMode.allowThreadDiskReads calls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

Issue 2851473007: Clean up StrictMode.allowThreadDiskReads calls. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/compositor/bottombar/contextualsearch/ContextualSearchQuickActionControl.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabTabPersistencePolicy.java » ('j') | chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrDaydreamApiImpl.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

index 9f65633596aa3cbd5f1fa831d40124438d012523..1024715c8791040def0680670380f9517e706bb8 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java

@@ -1019,8 +1019,7 @@ public class CustomTabActivity extends ChromeActivity {

intent.putExtra(ChromeLauncherActivity.EXTRA_IS_ALLOWED_TO_RETURN_TO_PARENT, false);

boolean willChromeHandleIntent = getIntentDataProvider().isOpenedByChrome();

- StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskReads();

- StrictMode.allowThreadDiskWrites();

+ StrictMode.ThreadPolicy oldPolicy = StrictMode.allowThreadDiskWrites();

try {

willChromeHandleIntent |= ExternalNavigationDelegateImpl

.willChromeHandleIntent(intent, true);

@@ -1046,7 +1045,6 @@ public class CustomTabActivity extends ChromeActivity {

tab.detachAndStartReparenting(intent, startActivityOptions, finalizeCallback);

} else {

// Temporarily allowing disk access while fixing. TODO: http://crbug.com/581860

- StrictMode.allowThreadDiskReads();

StrictMode.allowThreadDiskWrites();

try {

if (mIntentDataProvider.isInfoPage()) {