Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(543)

Issue 2851453003: Revert of Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (Closed)

Created:
3 years, 7 months ago by timvolodine
Modified:
3 years, 7 months ago
CC:
agrieve+watch_chromium.org, alokp+watch_chromium.org, asvitkine+watch_chromium.org, avayvod+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, jochen+watch_chromium.org, lcwu+watch_chromium.org, mlamouri+watch-media_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Peter Beverloo, piman+watch_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (patchset #2 id:20001 of https://codereview.chromium.org/2843913003/ ) Reason for revert: broke clang-clankium-tot-builder crbug.com/716075 (FullscreenWebContentsActivityTest not updated) Original issue's description: > Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. > > The flag should only be set by tests and will allow all autoplay related > restrictions such as autoplay policy and background playback to be > disabled. > > BUG=714676 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel > > Review-Url: https://codereview.chromium.org/2843913003 > Cr-Commit-Position: refs/heads/master@{#467692} > Committed: https://chromium.googlesource.com/chromium/src/+/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6 TBR=dalecurtis@chromium.org,jam@chromium.org,mlamouri@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=714676 Review-Url: https://codereview.chromium.org/2851453003 Cr-Commit-Position: refs/heads/master@{#467715} Committed: https://chromium.googlesource.com/chromium/src/+/54e35df000303d1a3b5214db2232aa2fb5c12e3a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -97 lines) Patch
M chrome/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PauseOnHeadsetUnplugTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/android/voice_search_tab_helper.cc View 1 chunk +3 lines, -7 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/media/defer_background_media_browsertest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +1 line, -2 lines 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 1 chunk +30 lines, -32 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/media/media_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/media/media_source_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/media/session/media_session_impl_visibility_browsertest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/webrtc/webrtc_capture_from_element_browsertest.cc View 2 chunks +1 line, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_integration_test.py View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
D media/base/android/java/src/org/chromium/media/MediaSwitches.java View 1 chunk +0 lines, -18 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +0 lines, -2 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/media.py View 2 chunks +3 lines, -2 lines 0 comments Download
M tools/perf/measurements/media.py View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
timvolodine
Created Revert of Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag.
3 years, 7 months ago (2017-04-27 17:12:43 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2851453003/1
3 years, 7 months ago (2017-04-27 17:13:24 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/54e35df000303d1a3b5214db2232aa2fb5c12e3a
3 years, 7 months ago (2017-04-27 17:15:00 UTC) #6
zmin
3 years, 7 months ago (2017-04-27 20:38:57 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2845973005/ by zmin@chromium.org.

The reason for reverting is: Reland the original patch as timvolodine and I
believe it's not related to the compile failure early today. .

Powered by Google App Engine
This is Rietveld 408576698