Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Issue 2843913003: Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (Closed)

Created:
3 years, 7 months ago by mlamouri (slow - plz ping)
Modified:
3 years, 7 months ago
Reviewers:
jam, DaleCurtis
CC:
agrieve+watch_chromium.org, alokp+watch_chromium.org, asvitkine+watch_chromium.org, avayvod+watch_chromium.org, chfremer+watch_chromium.org, chromium-reviews, creis+watch_chromium.org, darin-cc_chromium.org, feature-media-reviews_chromium.org, halliwell+watch_chromium.org, jochen+watch_chromium.org, lcwu+watch_chromium.org, mlamouri+watch-media_chromium.org, mlamouri+watch-content_chromium.org, nasko+codewatch_chromium.org, Peter Beverloo, piman+watch_chromium.org, telemetry-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. The flag should only be set by tests and will allow all autoplay related restrictions such as autoplay policy and background playback to be disabled. BUG=714676 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Review-Url: https://codereview.chromium.org/2843913003 Cr-Commit-Position: refs/heads/master@{#467692} Committed: https://chromium.googlesource.com/chromium/src/+/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6

Patch Set 1 #

Total comments: 12

Patch Set 2 : dalecurtis comments and deps update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -97 lines) Patch
M chrome/android/BUILD.gn View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/VideoFullscreenOrientationLockChromeTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/media/ui/PauseOnHeadsetUnplugTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M chrome/browser/android/voice_search_tab_helper.cc View 1 chunk +7 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 chunk +0 lines, -6 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 chunk +0 lines, -7 lines 0 comments Download
M chrome/browser/media/defer_background_media_browsertest.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/media/encrypted_media_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +2 lines, -1 line 0 comments Download
M chromecast/browser/cast_browser_main_parts.cc View 1 1 chunk +30 lines, -28 lines 0 comments Download
M content/browser/media/encrypted_media_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/media/media_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/media/media_source_browsertest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/media/session/media_session_impl_visibility_browsertest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/renderer_host/render_process_host_browsertest.cc View 2 chunks +2 lines, -3 lines 0 comments Download
M content/browser/renderer_host/render_process_host_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M content/browser/renderer_host/render_view_host_impl.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/webrtc/webrtc_capture_from_element_browsertest.cc View 2 chunks +2 lines, -1 line 0 comments Download
M content/public/android/java/src/org/chromium/content/common/ContentSwitches.java View 1 chunk +0 lines, -4 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/MediaSessionTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/javatests/src/org/chromium/content/browser/VideoFullscreenOrientationLockTest.java View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/shell/app/shell_main_delegate.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/test/gpu/gpu_tests/webgl_conformance_integration_test.py View 1 chunk +1 line, -1 line 0 comments Download
M media/base/android/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A media/base/android/java/src/org/chromium/media/MediaSwitches.java View 1 1 chunk +18 lines, -0 lines 0 comments Download
M media/base/media_switches.h View 1 chunk +2 lines, -0 lines 0 comments Download
M media/base/media_switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M tools/perf/benchmarks/blink_perf.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/benchmarks/media.py View 2 chunks +2 lines, -3 lines 0 comments Download
M tools/perf/measurements/media.py View 1 chunk +1 line, -2 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 26 (16 generated)
mlamouri (slow - plz ping)
dalecurtis@, PTAL This isn't doing much, really. I will follow-up on the Cast change in ...
3 years, 7 months ago (2017-04-26 19:24:24 UTC) #3
DaleCurtis
Description should be updated to indicate flag is renamed. https://codereview.chromium.org/2843913003/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/2843913003/diff/1/chrome/browser/about_flags.cc#oldcode1450 chrome/browser/about_flags.cc:1450: ...
3 years, 7 months ago (2017-04-26 19:39:21 UTC) #4
mlamouri (slow - plz ping)
Will update tomorrow. https://codereview.chromium.org/2843913003/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/2843913003/diff/1/chrome/browser/about_flags.cc#oldcode1450 chrome/browser/about_flags.cc:1450: {"disable-gesture-requirement-for-media-playback", On 2017/04/26 at 19:39:20, DaleCurtis ...
3 years, 7 months ago (2017-04-26 22:13:47 UTC) #5
DaleCurtis
lgtm https://codereview.chromium.org/2843913003/diff/1/chrome/browser/about_flags.cc File chrome/browser/about_flags.cc (left): https://codereview.chromium.org/2843913003/diff/1/chrome/browser/about_flags.cc#oldcode1450 chrome/browser/about_flags.cc:1450: {"disable-gesture-requirement-for-media-playback", On 2017/04/26 at 22:13:47, mlamouri wrote: > ...
3 years, 7 months ago (2017-04-26 22:37:43 UTC) #6
mlamouri (slow - plz ping)
+jam@ for global rubber-stamp. https://codereview.chromium.org/2843913003/diff/1/chromecast/browser/cast_browser_main_parts.cc File chromecast/browser/cast_browser_main_parts.cc (right): https://codereview.chromium.org/2843913003/diff/1/chromecast/browser/cast_browser_main_parts.cc#newcode221 chromecast/browser/cast_browser_main_parts.cc:221: // TODO(714676): this should probably ...
3 years, 7 months ago (2017-04-27 12:17:36 UTC) #15
jam
On 2017/04/27 12:17:36, mlamouri wrote: > +jam@ for global rubber-stamp. rs lgtm
3 years, 7 months ago (2017-04-27 15:33:10 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2843913003/20001
3 years, 7 months ago (2017-04-27 15:42:02 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/src/+/d1f8f6ca6c8b7cdaf02150099ce6db0cfc7223f6
3 years, 7 months ago (2017-04-27 15:50:09 UTC) #24
timvolodine
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2851453003/ by timvolodine@chromium.org. ...
3 years, 7 months ago (2017-04-27 17:12:43 UTC) #25
timvolodine
3 years, 7 months ago (2017-04-27 17:42:59 UTC) #26
Message was sent while issue was closed.
On 2017/04/27 17:12:43, timvolodine wrote:
> A revert of this CL (patchset #2 id:20001) has been created in
> https://codereview.chromium.org/2851453003/ by
mailto:timvolodine@chromium.org.
> 
> The reason for reverting is: broke clang-clankium-tot-builder crbug.com/716075
> 
> (FullscreenWebContentsActivityTest not updated).

As per crbug.com/716075 the reason was likely a different patch
https://codereview.chromium.org/2807663002.
This patch is probably fine and can be relanded, apologies for the confusion.

Powered by Google App Engine
This is Rietveld 408576698