Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Side by Side Diff: chrome/browser/media/defer_background_media_browsertest.cc

Issue 2851453003: Revert of Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/command_line.h" 5 #include "base/command_line.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "build/build_config.h" 7 #include "build/build_config.h"
8 #include "chrome/browser/ui/browser.h" 8 #include "chrome/browser/ui/browser.h"
9 #include "chrome/browser/ui/tabs/tab_strip_model.h" 9 #include "chrome/browser/ui/tabs/tab_strip_model.h"
10 #include "chrome/test/base/in_process_browser_test.h" 10 #include "chrome/test/base/in_process_browser_test.h"
11 #include "chrome/test/base/ui_test_utils.h" 11 #include "chrome/test/base/ui_test_utils.h"
12 #include "content/public/common/content_switches.h"
12 #include "content/public/test/browser_test_utils.h" 13 #include "content/public/test/browser_test_utils.h"
13 #include "media/base/media_switches.h"
14 #include "media/base/test_data_util.h" 14 #include "media/base/test_data_util.h"
15 15
16 class DeferredMediaBrowserTest : public InProcessBrowserTest { 16 class DeferredMediaBrowserTest : public InProcessBrowserTest {
17 public: 17 public:
18 #if defined(OS_ANDROID) 18 #if defined(OS_ANDROID)
19 void SetUpCommandLine(base::CommandLine* command_line) override { 19 void SetUpCommandLine(base::CommandLine* command_line) override {
20 command_line->AppendSwitch(switches::kIgnoreAutoplayRestrictionsForTests); 20 command_line->AppendSwitch(
21 switches::kDisableGestureRequirementForMediaPlayback);
21 } 22 }
22 #endif 23 #endif
23 }; 24 };
24 25
25 IN_PROC_BROWSER_TEST_F(DeferredMediaBrowserTest, BackgroundMediaIsDeferred) { 26 IN_PROC_BROWSER_TEST_F(DeferredMediaBrowserTest, BackgroundMediaIsDeferred) {
26 // Navigate to a video file, which would autoplay in the foreground, but won't 27 // Navigate to a video file, which would autoplay in the foreground, but won't
27 // in the background due to deferred media loading for hidden tabs. 28 // in the background due to deferred media loading for hidden tabs.
28 ui_test_utils::NavigateToURLWithDisposition( 29 ui_test_utils::NavigateToURLWithDisposition(
29 browser(), content::GetFileUrlWithQuery( 30 browser(), content::GetFileUrlWithQuery(
30 media::GetTestDataFilePath("bear-640x360.webm"), ""), 31 media::GetTestDataFilePath("bear-640x360.webm"), ""),
(...skipping 26 matching lines...) Expand all
57 EXPECT_EQ(background_contents, 58 EXPECT_EQ(background_contents,
58 browser()->tab_strip_model()->GetActiveWebContents()); 59 browser()->tab_strip_model()->GetActiveWebContents());
59 60
60 // If everything worked, we should see "playing" and not "ended". 61 // If everything worked, we should see "playing" and not "ended".
61 const base::string16 playing_str = base::UTF8ToUTF16("playing"); 62 const base::string16 playing_str = base::UTF8ToUTF16("playing");
62 const base::string16 ended_str = base::UTF8ToUTF16("ended"); 63 const base::string16 ended_str = base::UTF8ToUTF16("ended");
63 content::TitleWatcher watcher(background_contents, playing_str); 64 content::TitleWatcher watcher(background_contents, playing_str);
64 watcher.AlsoWaitForTitle(ended_str); 65 watcher.AlsoWaitForTitle(ended_str);
65 EXPECT_EQ(playing_str, watcher.WaitAndGetTitle()); 66 EXPECT_EQ(playing_str, watcher.WaitAndGetTitle());
66 } 67 }
OLDNEW
« no previous file with comments | « chrome/browser/flag_descriptions.cc ('k') | chrome/browser/media/encrypted_media_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698