Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: tools/perf/benchmarks/media.py

Issue 2851453003: Revert of Rename kDisableGestureRequirementForMediaPlayback and make it a test-only flag. (Closed)
Patch Set: Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « tools/perf/benchmarks/blink_perf.py ('k') | tools/perf/measurements/media.py » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from core import perf_benchmark 5 from core import perf_benchmark
6 6
7 from telemetry import benchmark 7 from telemetry import benchmark
8 from telemetry.page import legacy_page_test 8 from telemetry.page import legacy_page_test
9 from telemetry.timeline import chrome_trace_category_filter 9 from telemetry.timeline import chrome_trace_category_filter
10 from telemetry.value import list_of_scalar_values 10 from telemetry.value import list_of_scalar_values
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
143 return cls.IsSvelte(possible_browser) 143 return cls.IsSvelte(possible_browser)
144 144
145 @classmethod 145 @classmethod
146 def Name(cls): 146 def Name(cls):
147 return 'media.android.tough_video_cases_tbmv2' 147 return 'media.android.tough_video_cases_tbmv2'
148 148
149 def SetExtraBrowserOptions(self, options): 149 def SetExtraBrowserOptions(self, options):
150 # By default, Chrome on Android does not allow autoplay 150 # By default, Chrome on Android does not allow autoplay
151 # of media: it requires a user gesture event to start a video. 151 # of media: it requires a user gesture event to start a video.
152 # The following option works around that. 152 # The following option works around that.
153 options.AppendExtraBrowserArgs(['--ignore-autoplay-restrictions']) 153 options.AppendExtraBrowserArgs(
154 ['--disable-gesture-requirement-for-media-playback'])
154 155
155 156
156 @benchmark.Enabled('chromeos') 157 @benchmark.Enabled('chromeos')
157 class MediaChromeOS4kOnly(perf_benchmark.PerfBenchmark): 158 class MediaChromeOS4kOnly(perf_benchmark.PerfBenchmark):
158 """Benchmark for media performance on ChromeOS using only is_4k test content. 159 """Benchmark for media performance on ChromeOS using only is_4k test content.
159 """ 160 """
160 test = media.Media 161 test = media.Media
161 tag = 'chromeOS4kOnly' 162 tag = 'chromeOS4kOnly'
162 page_set = page_sets.ToughVideoCasesPageSet 163 page_set = page_sets.ToughVideoCasesPageSet
163 options = { 164 options = {
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
197 page_set = page_sets.MseCasesPageSet 198 page_set = page_sets.MseCasesPageSet
198 199
199 @classmethod 200 @classmethod
200 def Name(cls): 201 def Name(cls):
201 return 'media.mse_cases' 202 return 'media.mse_cases'
202 203
203 def SetExtraBrowserOptions(self, options): 204 def SetExtraBrowserOptions(self, options):
204 # Needed to allow XHR requests to return stream objects. 205 # Needed to allow XHR requests to return stream objects.
205 options.AppendExtraBrowserArgs( 206 options.AppendExtraBrowserArgs(
206 ['--enable-experimental-web-platform-features', 207 ['--enable-experimental-web-platform-features',
207 '--ignore-autoplay-restrictions']) 208 '--disable-gesture-requirement-for-media-playback'])
OLDNEW
« no previous file with comments | « tools/perf/benchmarks/blink_perf.py ('k') | tools/perf/measurements/media.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698