Fix appinstalled event firing when user opens a WebAPK from banner.

Fix appinstalled event firing when user opens a WebAPK from banner.

The "Open" button was calling SendBannerAccepted, which made the
assumption that the app was being installed. Removed this call and
documented the method's semantics.

BUG=716313
Review-Url: https://codereview.chromium.org/2848703005
Cr-Commit-Position: refs/heads/master@{#467903}
Committed: https://chromium.googlesource.com/chromium/src/+/d398f548f1929bf2a8307d02bc69065cd7cdc035

[Matt Giuca, 2017-04-28 03:53:10]

mgiuca@chromium.org changed reviewers:
+ dominickn@chromium.org

[Matt Giuca, 2017-04-28 03:53:11]

As with the previous change, I have no way to test this locally (WebAPK only),
so hoping to just test in Canary.

[dominickn, 2017-04-28 03:57:23]

lgtm % nit, thanks!

https://codereview.chromium.org/2848703005/diff/1/chrome/browser/android/bann...
File chrome/browser/android/banners/app_banner_infobar_delegate_android.h
(right):

https://codereview.chromium.org/2848703005/diff/1/chrome/browser/android/bann...
chrome/browser/android/banners/app_banner_infobar_delegate_android.h:125: //
Called when the user accepts the banner to install the app. (Not called
Nit: newline above this.

You should also clarify, something like.

If the banner is for a WebAPK, this is only called when the user begins the
installation process, not when they use the banner to open the WebAPK after
installation.

[Matt Giuca, 2017-04-28 03:59:19]

https://codereview.chromium.org/2848703005/diff/1/chrome/browser/android/bann...
File chrome/browser/android/banners/app_banner_infobar_delegate_android.h
(right):

https://codereview.chromium.org/2848703005/diff/1/chrome/browser/android/bann...
chrome/browser/android/banners/app_banner_infobar_delegate_android.h:125: //
Called when the user accepts the banner to install the app. (Not called
On 2017/04/28 03:57:23, dominickn wrote:
> Nit: newline above this.
> 
> You should also clarify, something like.
> 
> If the banner is for a WebAPK, this is only called when the user begins the
> installation process, not when they use the banner to open the WebAPK after
> installation.

My comment already mostly captures this. Worked WebAPKs into there.

[Matt Giuca, 2017-04-28 03:59:26]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2017-04-28 03:59:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
dominickn@chromium.org
Link to the patchset: https://codereview.chromium.org/2848703005/#ps20001
(title: "Better comment.")

[commit-bot: I haz the power, 2017-04-28 03:59:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 05:30:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493351966900640,
"parent_rev": "a1336afb916a5ea783cf76454f8804ac12709624", "commit_rev":
"d398f548f1929bf2a8307d02bc69065cd7cdc035"}

[commit-bot: I haz the power, 2017-04-28 05:31:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493351966900640,
"parent_rev": "a1336afb916a5ea783cf76454f8804ac12709624", "commit_rev":
"d398f548f1929bf2a8307d02bc69065cd7cdc035"}

[commit-bot: I haz the power, 2017-04-28 05:31:18]

Description was changed from

==========
Fix appinstalled event firing when user opens a WebAPK from banner.

The "Open" button was calling SendBannerAccepted, which made the
assumption that the app was being installed. Removed this call and
documented the method's semantics.

BUG=716313
==========

to

==========
Fix appinstalled event firing when user opens a WebAPK from banner.

The "Open" button was calling SendBannerAccepted, which made the
assumption that the app was being installed. Removed this call and
documented the method's semantics.

BUG=716313

Review-Url: https://codereview.chromium.org/2848703005
Cr-Commit-Position: refs/heads/master@{#467903}
Committed:
https://chromium.googlesource.com/chromium/src/+/d398f548f1929bf2a8307d02bc69...
==========

[commit-bot: I haz the power, 2017-04-28 05:31:19]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d398f548f1929bf2a8307d02bc69...