Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Side by Side Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Issue 2848703005: Fix appinstalled event firing when user opens a WebAPK from banner. (Closed)
Patch Set: Better comment. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate_android.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h" 5 #include "chrome/browser/android/banners/app_banner_infobar_delegate_android.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_string.h" 10 #include "base/android/jni_string.h"
(...skipping 285 matching lines...) Expand 10 before | Expand all | Expand 10 after
296 } 296 }
297 297
298 bool AppBannerInfoBarDelegateAndroid::AcceptWebApk( 298 bool AppBannerInfoBarDelegateAndroid::AcceptWebApk(
299 content::WebContents* web_contents) { 299 content::WebContents* web_contents) {
300 if (IsInfoEmpty(shortcut_info_)) 300 if (IsInfoEmpty(shortcut_info_))
301 return true; 301 return true;
302 302
303 JNIEnv* env = base::android::AttachCurrentThread(); 303 JNIEnv* env = base::android::AttachCurrentThread();
304 304
305 // If the WebAPK is installed and the "Open" button is clicked, open the 305 // If the WebAPK is installed and the "Open" button is clicked, open the
306 // WebAPK. 306 // WebAPK. Do not send a BannerAccepted message.
307 if (install_state_ == INSTALLED) { 307 if (install_state_ == INSTALLED) {
308 Java_AppBannerInfoBarDelegateAndroid_openWebApk(env, java_delegate_); 308 Java_AppBannerInfoBarDelegateAndroid_openWebApk(env, java_delegate_);
309 webapk::TrackUserAction(webapk::USER_ACTION_INSTALLED_OPEN); 309 webapk::TrackUserAction(webapk::USER_ACTION_INSTALLED_OPEN);
310 SendBannerAccepted();
311 return true; 310 return true;
312 } 311 }
313 312
314 install_state_ = INSTALLING; 313 install_state_ = INSTALLING;
315 webapk::TrackInstallSource(webapk_install_source_); 314 webapk::TrackInstallSource(webapk_install_source_);
316 315
317 if (TriggeredFromBanner()) { 316 if (TriggeredFromBanner()) {
318 TrackUserResponse(USER_RESPONSE_WEB_APP_ACCEPTED); 317 TrackUserResponse(USER_RESPONSE_WEB_APP_ACCEPTED);
319 AppBannerSettingsHelper::RecordBannerInstallEvent( 318 AppBannerSettingsHelper::RecordBannerInstallEvent(
320 web_contents, shortcut_info_->url.spec(), AppBannerSettingsHelper::WEB); 319 web_contents, shortcut_info_->url.spec(), AppBannerSettingsHelper::WEB);
(...skipping 143 matching lines...) Expand 10 before | Expand all | Expand 10 after
464 463
465 TrackDismissEvent(DISMISS_EVENT_BANNER_CLICK); 464 TrackDismissEvent(DISMISS_EVENT_BANNER_CLICK);
466 return true; 465 return true;
467 } 466 }
468 467
469 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env) { 468 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env) {
470 return RegisterNativesImpl(env); 469 return RegisterNativesImpl(env);
471 } 470 }
472 471
473 } // namespace banners 472 } // namespace banners
OLDNEW
« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698