Fix appinstalled event firing when user opens a WebAPK from banner.

chrome/browser/android/banners/app_banner_infobar_delegate_android.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_
 #define CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_
 
 #include <memory>
 #include <string>
 
@@ skipping 104 matching lines @@
   bool AcceptWebApp(content::WebContents* web_contents);
 
   // Called when the OK button on a WebAPK infobar is pressed. If the WebAPK is
   // already installed, opens it; otherwise, installs it. Returns whether the
   // infobar should be closed as a result of the button press.
   bool AcceptWebApk(content::WebContents* web_contents);
 
   // Returns false if this delegate is for a WebAPK and was triggered from the
   // A2HS menu item. Otherwise returns true.
   bool TriggeredFromBanner() const;
+  // Called when the user accepts the banner to install the app. (Not called

[dominickn, 2017/04/28 03:57:23]

Nit: newline above this.

You should also clarify, something like.

If the banner is for a WebAPK, this is only called when the user begins the
installation process, not when they use the banner to open the WebAPK after
installation.

[Matt Giuca, 2017/04/28 03:59:18]

My comment already mostly captures this. Worked WebAPKs into there.

+  // when the "Open" button is pressed on the banner after installation.)
   void SendBannerAccepted();
   void OnWebApkInstallFinished(WebApkInstallResult result,
                                bool relax_updates,
                                const std::string& webapk_package_name);
 
   // Called when a WebAPK install fails.
   void OnWebApkInstallFailed(WebApkInstallResult result);
 
   void TrackWebApkInstallationDismissEvents(InstallState install_state);
 
@@ skipping 36 matching lines @@
 
   DISALLOW_COPY_AND_ASSIGN(AppBannerInfoBarDelegateAndroid);
 };
 
 // Register native methods.
 bool RegisterAppBannerInfoBarDelegateAndroid(JNIEnv* env);
 
 }  // namespace banners
 
 #endif  // CHROME_BROWSER_ANDROID_BANNERS_APP_BANNER_INFOBAR_DELEGATE_ANDROID_H_