Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Unified Diff: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc

Issue 2848703005: Fix appinstalled event firing when user opens a WebAPK from banner. (Closed)
Patch Set: Better comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate_android.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
diff --git a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
index c0b69b8270aa85d7f07b074489deaec14d67ba4f..5d8f0190b130def904f7e8c3ff335a448745be82 100644
--- a/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
+++ b/chrome/browser/android/banners/app_banner_infobar_delegate_android.cc
@@ -303,11 +303,10 @@ bool AppBannerInfoBarDelegateAndroid::AcceptWebApk(
JNIEnv* env = base::android::AttachCurrentThread();
// If the WebAPK is installed and the "Open" button is clicked, open the
- // WebAPK.
+ // WebAPK. Do not send a BannerAccepted message.
if (install_state_ == INSTALLED) {
Java_AppBannerInfoBarDelegateAndroid_openWebApk(env, java_delegate_);
webapk::TrackUserAction(webapk::USER_ACTION_INSTALLED_OPEN);
- SendBannerAccepted();
return true;
}
« no previous file with comments | « chrome/browser/android/banners/app_banner_infobar_delegate_android.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698