Introduce the abstract class WebViewBase, to decouple WebViewImpl.

Introduce the abstract class WebViewBase, to decouple WebViewImpl.

In Source/web/ there are many cyclic dependencies. These cycles make it very
difficult to discretely move class implementation from web/ to either core/ or
modules/. 

An example cycle is WebViewImpl and WebLocalFrameImpl. Each refer to the other,
rather than the least derived types of WebView and WebLocalFrame (or WebFrame).
It is impossible to use the least derived type as methods have been added to the
*Impl class definitions that are consumed by other classes in Source/web.

To break the cycle we introduce the class WebViewBase, so that the inheritance
hierarchy is now WebView <- WebViewBase <- WebViewImpl (<- = implements). 

Methods that were defined in WebViewImpl are made pure virtual in WebViewBase, 
and now classes that were taking a dependency on WebViewImpl instead now take a 
dependency on WebViewBase. This breaks the dependency chain and allows us to 
start moving these classes out of Source/web into new homes in modules or core.
Note: WebViewBase is defined in core/exported/WebViewBase.h as is implements
public/web/WebView.h. Once this refactoring is complete WebViewBase will be 
removed and these changes effectively reverted.

This CL moves the first portion of classes to use WebViewBase rather than 
WebViewImpl, a followup CL will complete this move.

BUG=712963
Review-Url: https://codereview.chromium.org/2848513002
Cr-Commit-Position: refs/heads/master@{#467905}
Committed: https://chromium.googlesource.com/chromium/src/+/ff3d745c3a244f84d791ea20bd70dd3c9b86a160

[slangley, 2017-04-27 06:25:21]

Description was changed from

==========
Introduce the abstract class WebViewBase, to decouple WebViewImpl.



BUG=
==========

to

==========
Introduce the abstract class WebViewBase, to decouple WebViewImpl.



BUG=712963
==========

[slangley, 2017-04-27 06:37:43]

Description was changed from

==========
Introduce the abstract class WebViewBase, to decouple WebViewImpl.



BUG=712963
==========

to

==========
Introduce the abstract class WebViewBase, to decouple WebViewImpl.

In Source/web/ there are many cyclic dependencies. These cycles make it very
difficult to discretely move class implementation from web/ to either core/ or
modules/. 

An example cycle is WebViewImpl and WebLocalFrameImpl. Each refer to the other,
rather than the least derived types of WebView and WebLocalFrame (or WebFrame).
It is impossible to use the least derived type as methods have been added to the
*Impl class definitions that are consumed by other classes in Source/web.

To break the cycle we introduce the class WebViewBase, so that the inheritance
hierarchy is now WebView <- WebViewBase <- WebViewImpl (<- = implements). 

Methods that were defined in WebViewImpl are made pure virtual in WebViewBase, 
and now classes that were taking a dependency on WebViewImpl instead now take a 
dependency on WebViewBase. This breaks the dependency chain and allows us to 
start moving these classes out of Source/web into new homes in modules or core.

This CL moves the first portion of classes to use WebViewBase rather than 
WebView, a followup CL will complete this move.

BUG=712963
==========

[slangley, 2017-04-27 06:38:59]

Description was changed from

==========
Introduce the abstract class WebViewBase, to decouple WebViewImpl.

In Source/web/ there are many cyclic dependencies. These cycles make it very
difficult to discretely move class implementation from web/ to either core/ or
modules/. 

An example cycle is WebViewImpl and WebLocalFrameImpl. Each refer to the other,
rather than the least derived types of WebView and WebLocalFrame (or WebFrame).
It is impossible to use the least derived type as methods have been added to the
*Impl class definitions that are consumed by other classes in Source/web.

To break the cycle we introduce the class WebViewBase, so that the inheritance
hierarchy is now WebView <- WebViewBase <- WebViewImpl (<- = implements). 

Methods that were defined in WebViewImpl are made pure virtual in WebViewBase, 
and now classes that were taking a dependency on WebViewImpl instead now take a 
dependency on WebViewBase. This breaks the dependency chain and allows us to 
start moving these classes out of Source/web into new homes in modules or core.

This CL moves the first portion of classes to use WebViewBase rather than 
WebView, a followup CL will complete this move.

BUG=712963
==========

to

==========
Introduce the abstract class WebViewBase, to decouple WebViewImpl.

In Source/web/ there are many cyclic dependencies. These cycles make it very
difficult to discretely move class implementation from web/ to either core/ or
modules/. 

An example cycle is WebViewImpl and WebLocalFrameImpl. Each refer to the other,
rather than the least derived types of WebView and WebLocalFrame (or WebFrame).
It is impossible to use the least derived type as methods have been added to the
*Impl class definitions that are consumed by other classes in Source/web.

To break the cycle we introduce the class WebViewBase, so that the inheritance
hierarchy is now WebView <- WebViewBase <- WebViewImpl (<- = implements). 

Methods that were defined in WebViewImpl are made pure virtual in WebViewBase, 
and now classes that were taking a dependency on WebViewImpl instead now take a 
dependency on WebViewBase. This breaks the dependency chain and allows us to 
start moving these classes out of Source/web into new homes in modules or core.
Note: WebViewBase is defined in core/exported/WebViewBase.h as is implements
public/web/WebView.h. Once this refactoring is complete WebViewBase will be 
removed and these changes effectively reverted.

This CL moves the first portion of classes to use WebViewBase rather than 
WebView, a followup CL will complete this move.

BUG=712963
==========

[slangley, 2017-04-27 06:40:22]

slangley@chromium.org changed reviewers:
+ haraken@chromium.org, tkent@chromium.org

[slangley, 2017-04-27 06:40:24]

haraken@, tkent@ PTAL

This is the alternate method discussed on a previous CL to allow us to break
dependencies between *Impl classes in Source/web, without having to push new
methods into the public API.

[slangley, 2017-04-27 06:40:48]

Description was changed from

==========
Introduce the abstract class WebViewBase, to decouple WebViewImpl.

In Source/web/ there are many cyclic dependencies. These cycles make it very
difficult to discretely move class implementation from web/ to either core/ or
modules/. 

An example cycle is WebViewImpl and WebLocalFrameImpl. Each refer to the other,
rather than the least derived types of WebView and WebLocalFrame (or WebFrame).
It is impossible to use the least derived type as methods have been added to the
*Impl class definitions that are consumed by other classes in Source/web.

To break the cycle we introduce the class WebViewBase, so that the inheritance
hierarchy is now WebView <- WebViewBase <- WebViewImpl (<- = implements). 

Methods that were defined in WebViewImpl are made pure virtual in WebViewBase, 
and now classes that were taking a dependency on WebViewImpl instead now take a 
dependency on WebViewBase. This breaks the dependency chain and allows us to 
start moving these classes out of Source/web into new homes in modules or core.
Note: WebViewBase is defined in core/exported/WebViewBase.h as is implements
public/web/WebView.h. Once this refactoring is complete WebViewBase will be 
removed and these changes effectively reverted.

This CL moves the first portion of classes to use WebViewBase rather than 
WebView, a followup CL will complete this move.

BUG=712963
==========

to

==========
Introduce the abstract class WebViewBase, to decouple WebViewImpl.

In Source/web/ there are many cyclic dependencies. These cycles make it very
difficult to discretely move class implementation from web/ to either core/ or
modules/. 

An example cycle is WebViewImpl and WebLocalFrameImpl. Each refer to the other,
rather than the least derived types of WebView and WebLocalFrame (or WebFrame).
It is impossible to use the least derived type as methods have been added to the
*Impl class definitions that are consumed by other classes in Source/web.

To break the cycle we introduce the class WebViewBase, so that the inheritance
hierarchy is now WebView <- WebViewBase <- WebViewImpl (<- = implements). 

Methods that were defined in WebViewImpl are made pure virtual in WebViewBase, 
and now classes that were taking a dependency on WebViewImpl instead now take a 
dependency on WebViewBase. This breaks the dependency chain and allows us to 
start moving these classes out of Source/web into new homes in modules or core.
Note: WebViewBase is defined in core/exported/WebViewBase.h as is implements
public/web/WebView.h. Once this refactoring is complete WebViewBase will be 
removed and these changes effectively reverted.

This CL moves the first portion of classes to use WebViewBase rather than 
WebViewImpl, a followup CL will complete this move.

BUG=712963
==========

[tkent, 2017-04-27 07:47:53]

lgtm

[slangley, 2017-04-27 11:14:30]

The CQ bit was checked by slangley@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 11:14:37]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 11:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 11:32:54]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[haraken, 2017-04-27 12:42:04]

LGTM

https://codereview.chromium.org/2848513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/exported/WebViewBase.h (right):

https://codereview.chromium.org/2848513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/exported/WebViewBase.h:1: #ifndef WebViewBase_h

Add a copyright.

[slangley, 2017-04-28 00:16:21]

Thanks!

https://codereview.chromium.org/2848513002/diff/20001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/exported/WebViewBase.h (right):

https://codereview.chromium.org/2848513002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/exported/WebViewBase.h:1: #ifndef WebViewBase_h
On 2017/04/27 at 12:42:04, haraken wrote:
> Add a copyright.

Done!

[slangley, 2017-04-28 01:44:57]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-04-28 01:44:57]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org,
haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2848513002/#ps40001
(title: "Fix code review comments & MACOS build failure.")

[commit-bot: I haz the power, 2017-04-28 01:46:24]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:12:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 02:12:42]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[slangley, 2017-04-28 02:39:16]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-04-28 02:39:17]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2848513002/#ps60001
(title: "Define SendContextMenuEvent for MACOS and return kNotHandled, to avoid
link errors.")

[commit-bot: I haz the power, 2017-04-28 02:40:15]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 03:01:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 03:01:42]

Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[slangley, 2017-04-28 03:33:26]

The CQ bit was checked by slangley@chromium.org

[slangley, 2017-04-28 03:33:26]

The patchset sent to the CQ was uploaded after l-g-t-m from
haraken@chromium.org, tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2848513002/#ps80001
(title: "Fix typo.")

[commit-bot: I haz the power, 2017-04-28 03:34:05]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 05:40:06]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1493350406027910,
"parent_rev": "e9b8dd05acbcbfbee383a0ba3be81bfe720cdbdb", "commit_rev":
"ff3d745c3a244f84d791ea20bd70dd3c9b86a160"}

[commit-bot: I haz the power, 2017-04-28 05:40:13]

Description was changed from

==========
Introduce the abstract class WebViewBase, to decouple WebViewImpl.

In Source/web/ there are many cyclic dependencies. These cycles make it very
difficult to discretely move class implementation from web/ to either core/ or
modules/. 

An example cycle is WebViewImpl and WebLocalFrameImpl. Each refer to the other,
rather than the least derived types of WebView and WebLocalFrame (or WebFrame).
It is impossible to use the least derived type as methods have been added to the
*Impl class definitions that are consumed by other classes in Source/web.

To break the cycle we introduce the class WebViewBase, so that the inheritance
hierarchy is now WebView <- WebViewBase <- WebViewImpl (<- = implements). 

Methods that were defined in WebViewImpl are made pure virtual in WebViewBase, 
and now classes that were taking a dependency on WebViewImpl instead now take a 
dependency on WebViewBase. This breaks the dependency chain and allows us to 
start moving these classes out of Source/web into new homes in modules or core.
Note: WebViewBase is defined in core/exported/WebViewBase.h as is implements
public/web/WebView.h. Once this refactoring is complete WebViewBase will be 
removed and these changes effectively reverted.

This CL moves the first portion of classes to use WebViewBase rather than 
WebViewImpl, a followup CL will complete this move.

BUG=712963
==========

to

==========
Introduce the abstract class WebViewBase, to decouple WebViewImpl.

In Source/web/ there are many cyclic dependencies. These cycles make it very
difficult to discretely move class implementation from web/ to either core/ or
modules/. 

An example cycle is WebViewImpl and WebLocalFrameImpl. Each refer to the other,
rather than the least derived types of WebView and WebLocalFrame (or WebFrame).
It is impossible to use the least derived type as methods have been added to the
*Impl class definitions that are consumed by other classes in Source/web.

To break the cycle we introduce the class WebViewBase, so that the inheritance
hierarchy is now WebView <- WebViewBase <- WebViewImpl (<- = implements). 

Methods that were defined in WebViewImpl are made pure virtual in WebViewBase, 
and now classes that were taking a dependency on WebViewImpl instead now take a 
dependency on WebViewBase. This breaks the dependency chain and allows us to 
start moving these classes out of Source/web into new homes in modules or core.
Note: WebViewBase is defined in core/exported/WebViewBase.h as is implements
public/web/WebView.h. Once this refactoring is complete WebViewBase will be 
removed and these changes effectively reverted.

This CL moves the first portion of classes to use WebViewBase rather than 
WebViewImpl, a followup CL will complete this move.

BUG=712963

Review-Url: https://codereview.chromium.org/2848513002
Cr-Commit-Position: refs/heads/master@{#467905}
Committed:
https://chromium.googlesource.com/chromium/src/+/ff3d745c3a244f84d791ea20bd70...
==========

[commit-bot: I haz the power, 2017-04-28 05:40:15]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/ff3d745c3a244f84d791ea20bd70...