Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1497)

Unified Diff: third_party/WebKit/Source/web/ExternalPopupMenu.h

Issue 2848513002: Introduce the abstract class WebViewBase, to decouple WebViewImpl. (Closed)
Patch Set: Fix typo. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ExternalPopupMenu.h
diff --git a/third_party/WebKit/Source/web/ExternalPopupMenu.h b/third_party/WebKit/Source/web/ExternalPopupMenu.h
index 516930eabef37a7e890e3a66676d279b926f3bf3..aa6d80191134e7f8d4a9e3c362108df36c53885a 100644
--- a/third_party/WebKit/Source/web/ExternalPopupMenu.h
+++ b/third_party/WebKit/Source/web/ExternalPopupMenu.h
@@ -46,7 +46,7 @@ class HTMLSelectElement;
class LocalFrame;
class WebExternalPopupMenu;
class WebMouseEvent;
-class WebViewImpl;
+class WebView;
struct WebPopupMenuInfo;
// The ExternalPopupMenu connects the actual implementation of the popup menu
@@ -54,7 +54,7 @@ struct WebPopupMenuInfo;
class WEB_EXPORT ExternalPopupMenu final : NON_EXPORTED_BASE(public PopupMenu),
public WebExternalPopupMenuClient {
public:
- ExternalPopupMenu(LocalFrame&, HTMLSelectElement&, WebViewImpl&);
+ ExternalPopupMenu(LocalFrame&, HTMLSelectElement&, WebView&);
~ExternalPopupMenu() override;
// Fills |info| with the popup menu information contained in the
@@ -86,7 +86,7 @@ class WEB_EXPORT ExternalPopupMenu final : NON_EXPORTED_BASE(public PopupMenu),
Member<HTMLSelectElement> owner_element_;
Member<LocalFrame> local_frame_;
- WebViewImpl& web_view_;
+ WebView& web_view_;
std::unique_ptr<WebMouseEvent> synthetic_event_;
TaskRunnerTimer<ExternalPopupMenu> dispatch_event_timer_;
// The actual implementor of the show menu.
« no previous file with comments | « third_party/WebKit/Source/web/EditorClientImpl.cpp ('k') | third_party/WebKit/Source/web/ExternalPopupMenu.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698