Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: third_party/WebKit/Source/web/LocalFrameClientImpl.cpp

Issue 2848513002: Introduce the abstract class WebViewBase, to decouple WebViewImpl. (Closed)
Patch Set: Fix typo. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
diff --git a/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp b/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
index ae19064b0caab95b2a57901b2310c0db0a1729fc..57244ef85a686828b04403191515f5340321f5f9 100644
--- a/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
+++ b/third_party/WebKit/Source/web/LocalFrameClientImpl.cpp
@@ -39,6 +39,7 @@
#include "core/events/MouseEvent.h"
#include "core/events/UIEventWithKeyState.h"
#include "core/exported/WebDataSourceImpl.h"
+#include "core/exported/WebViewBase.h"
#include "core/frame/FrameView.h"
#include "core/frame/Settings.h"
#include "core/html/HTMLFrameElementBase.h"
@@ -106,7 +107,6 @@
#include "web/WebDevToolsFrontendImpl.h"
#include "web/WebLocalFrameImpl.h"
#include "web/WebPluginContainerImpl.h"
-#include "web/WebViewImpl.h"
#include <memory>
@@ -424,7 +424,7 @@ void LocalFrameClientImpl::DispatchDidChangeThemeColor() {
}
static bool AllowCreatingBackgroundTabs() {
- const WebInputEvent* input_event = WebViewImpl::CurrentInputEvent();
+ const WebInputEvent* input_event = WebViewBase::CurrentInputEvent();
if (!input_event || (input_event->GetType() != WebInputEvent::kMouseUp &&
(input_event->GetType() != WebInputEvent::kRawKeyDown &&
input_event->GetType() != WebInputEvent::kKeyDown) &&
@@ -587,7 +587,7 @@ void LocalFrameClientImpl::LoadErrorPage(int reason) {
}
bool LocalFrameClientImpl::NavigateBackForward(int offset) const {
- WebViewImpl* webview = web_frame_->ViewImpl();
+ WebViewBase* webview = web_frame_->ViewImpl();
if (!webview->Client())
return false;
@@ -937,7 +937,7 @@ void LocalFrameClientImpl::DispatchDidChangeManifest() {
}
unsigned LocalFrameClientImpl::BackForwardLength() {
- WebViewImpl* webview = web_frame_->ViewImpl();
+ WebViewBase* webview = web_frame_->ViewImpl();
if (!webview || !webview->Client())
return 0;
return webview->Client()->HistoryBackListCount() + 1 +
« no previous file with comments | « third_party/WebKit/Source/web/LinkHighlightImplTest.cpp ('k') | third_party/WebKit/Source/web/PageOverlayTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698