Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp

Issue 2848513002: Introduce the abstract class WebViewBase, to decouple WebViewImpl. (Closed)
Patch Set: Fix typo. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
diff --git a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
index 5d216186dd4eefd8d0e0253544b510201872e704..0b60b716c9075a1f5f5e6b9e1e5638ce6493ce88 100644
--- a/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
+++ b/third_party/WebKit/Source/web/WebLocalFrameImpl.cpp
@@ -123,6 +123,7 @@
#include "core/editing/spellcheck/SpellChecker.h"
#include "core/exported/WebAssociatedURLLoaderImpl.h"
#include "core/exported/WebDataSourceImpl.h"
+#include "core/exported/WebViewBase.h"
#include "core/frame/FrameView.h"
#include "core/frame/LocalDOMWindow.h"
#include "core/frame/PageScaleConstraintsSet.h"
@@ -230,7 +231,6 @@
#include "web/WebFrameWidgetImpl.h"
#include "web/WebPluginContainerImpl.h"
#include "web/WebRemoteFrameImpl.h"
-#include "web/WebViewImpl.h"
namespace blink {
@@ -1736,7 +1736,7 @@ void WebLocalFrameImpl::CreateFrameView() {
DCHECK(GetFrame()); // If frame() doesn't exist, we probably didn't init
// properly.
- WebViewImpl* web_view = ViewImpl();
+ WebViewBase* web_view = ViewImpl();
// Check if we're shutting down.
if (!web_view->GetPage())
@@ -1785,7 +1785,7 @@ WebLocalFrameImpl* WebLocalFrameImpl::FromFrameOwnerElement(Element* element) {
ToLocalFrame(ToHTMLFrameOwnerElement(element)->ContentFrame()));
}
-WebViewImpl* WebLocalFrameImpl::ViewImpl() const {
+WebViewBase* WebLocalFrameImpl::ViewImpl() const {
if (!GetFrame())
return nullptr;
return WebViewImpl::FromPage(GetFrame()->GetPage());
« no previous file with comments | « third_party/WebKit/Source/web/WebLocalFrameImpl.h ('k') | third_party/WebKit/Source/web/WebPluginContainerImpl.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698