Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2848413002: Revert of Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk (Closed)

Created:
3 years, 7 months ago by robliao
Modified:
3 years, 7 months ago
Reviewers:
jam, rkaplow
CC:
chromium-reviews, jam, danakj+watch_chromium.org, darin-cc_chromium.org, vmpstr+watch_chromium.org, gab, fdoray
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk (patchset #1 id:1 of https://codereview.chromium.org/2856583002/ ) Reason for revert: Possible failure: https://luci-logdog.appspot.com/v/?s=chromium%2Fbb%2Fchromium.chromiumos%2FLinux_ChromiumOS_Tests__dbg__1_%2F25521%2F%2B%2Frecipes%2Fsteps%2Fbrowser_tests%2F0%2Flogs%2FCaptivePortalWindowTest.OnRedirected%2F0 Original issue's description: > Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk > > This reverts commit f07732ec0e39ad7e9f1ad279f2624dbdf261803d > (https://codereview.chromium.org/2791933004) > and reapplies b6d0c9a06ab573af760763fcd7ecf76ae2c87695 > (https://codereview.chromium.org/2690183002/). > > BUG=653916, 707986 > TBR=jam@chromium.org, rkaplow@chromium.org > Previously reviewed at https://codereview.chromium.org/2690183002/ > > Review-Url: https://codereview.chromium.org/2856583002 > Cr-Commit-Position: refs/heads/master@{#468376} > Committed: https://chromium.googlesource.com/chromium/src/+/3e27cb6e501ae55d614b56d566487590518ec223 TBR=jam@chromium.org,rkaplow@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=653916, 707986 Review-Url: https://codereview.chromium.org/2848413002 Cr-Commit-Position: refs/heads/master@{#468481} Committed: https://chromium.googlesource.com/chromium/src/+/d4be08b81e51bbf512152939dce9955133f74864

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -84 lines) Patch
M base/threading/thread_restrictions.h View 3 chunks +1 line, -3 lines 0 comments Download
M content/browser/browser_main_loop.cc View 1 chunk +78 lines, -80 lines 0 comments Download
M testing/variations/fieldtrial_testing_config.json View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 6 (3 generated)
robliao
Created Revert of Reland RedirectNonUINonIOBrowserThreads to TaskScheduler by default on trunk
3 years, 7 months ago (2017-05-01 23:31:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2848413002/1
3 years, 7 months ago (2017-05-01 23:32:14 UTC) #3
commit-bot: I haz the power
3 years, 7 months ago (2017-05-01 23:34:30 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d4be08b81e51bbf512152939dce9...

Powered by Google App Engine
This is Rietveld 408576698