Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2845913003: Cleaned up unused methods from WebStateImpl and NavigationContextImpl. (Closed)

Created:
3 years, 7 months ago by Eugene But (OOO till 7-30)
Modified:
3 years, 7 months ago
Reviewers:
kkhorimoto
CC:
chromium-reviews, ios-reviews_chromium.org, ios-reviews+web_chromium.org, baxley+watch_chromium.org, Eugene But (OOO till 7-30), huangml+watch_chromium.org, liaoyuke+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Cleaned up unused methods from WebStateImpl and NavigationContextImpl. BUG=None Review-Url: https://codereview.chromium.org/2845913003 Cr-Commit-Position: refs/heads/master@{#471066} Committed: https://chromium.googlesource.com/chromium/src/+/d079cb94526e59edd13dc1e71201c750e67257c7

Patch Set 1 #

Patch Set 2 : Rebased #

Patch Set 3 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -209 lines) Patch
M ios/chrome/browser/tabs/DEPS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ios/chrome/browser/tabs/tab_unittest.mm View 1 2 2 chunks +5 lines, -1 line 0 comments Download
M ios/web/public/test/fakes/crw_test_web_state_observer.mm View 1 chunk +7 lines, -17 lines 0 comments Download
M ios/web/public/test/fakes/test_web_state_observer.mm View 1 chunk +8 lines, -18 lines 0 comments Download
M ios/web/web_state/navigation_context_impl.h View 1 chunk +0 lines, -17 lines 0 comments Download
M ios/web/web_state/navigation_context_impl.mm View 1 chunk +0 lines, -34 lines 0 comments Download
M ios/web/web_state/navigation_context_impl_unittest.mm View 2 chunks +0 lines, -42 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 chunks +8 lines, -6 lines 0 comments Download
M ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm View 1 3 chunks +9 lines, -8 lines 0 comments Download
M ios/web/web_state/web_state_impl.h View 1 1 chunk +0 lines, -9 lines 0 comments Download
M ios/web/web_state/web_state_impl.mm View 1 1 chunk +0 lines, -23 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 2 chunks +2 lines, -32 lines 0 comments Download
M ios/web/web_state/web_state_observer_bridge_unittest.mm View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 21 (17 generated)
Eugene But (OOO till 7-30)
3 years, 7 months ago (2017-04-28 07:45:43 UTC) #6
kkhorimoto
lgtm
3 years, 7 months ago (2017-04-28 17:23:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2845913003/40001
3 years, 7 months ago (2017-05-11 20:42:51 UTC) #18
commit-bot: I haz the power
3 years, 7 months ago (2017-05-11 20:51:45 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/d079cb94526e59edd13dc1e71201...

Powered by Google App Engine
This is Rietveld 408576698