Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Unified Diff: ios/web/web_state/ui/crw_web_controller.mm

Issue 2845913003: Cleaned up unused methods from WebStateImpl and NavigationContextImpl. (Closed)
Patch Set: Fixed tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/web/web_state/ui/crw_web_controller.mm
diff --git a/ios/web/web_state/ui/crw_web_controller.mm b/ios/web/web_state/ui/crw_web_controller.mm
index 20eb3c3c788ee8dff294274e37704a2ddcea7bc6..ef9d4bd1dcc9b4acf23e91bbe6b490f279f3ff7c 100644
--- a/ios/web/web_state/ui/crw_web_controller.mm
+++ b/ios/web/web_state/ui/crw_web_controller.mm
@@ -1343,9 +1343,10 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
[[self sessionController] pushNewItemWithURL:pageURL
stateObject:stateObject
transition:transition];
- std::unique_ptr<web::NavigationContext> context =
- web::NavigationContextImpl::CreateSameDocumentNavigationContext(
- _webStateImpl, pageURL);
+ std::unique_ptr<web::NavigationContextImpl> context =
+ web::NavigationContextImpl::CreateNavigationContext(_webStateImpl,
+ pageURL);
+ context->SetIsSameDocument(true);
_webStateImpl->OnNavigationFinished(context.get());
self.userInteractionRegistered = NO;
}
@@ -1355,9 +1356,10 @@ const NSTimeInterval kSnapshotOverlayTransition = 0.5;
_webStateImpl->OnProvisionalNavigationStarted(pageURL);
[[self sessionController] updateCurrentItemWithURL:pageURL
stateObject:stateObject];
- std::unique_ptr<web::NavigationContext> context =
- web::NavigationContextImpl::CreateSameDocumentNavigationContext(
- _webStateImpl, pageURL);
+ std::unique_ptr<web::NavigationContextImpl> context =
+ web::NavigationContextImpl::CreateNavigationContext(_webStateImpl,
+ pageURL);
+ context->SetIsSameDocument(true);
_webStateImpl->OnNavigationFinished(context.get());
}
« no previous file with comments | « ios/web/web_state/navigation_context_impl_unittest.mm ('k') | ios/web/web_state/ui/crw_wk_navigation_states_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698