Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1053)

Unified Diff: ios/chrome/browser/tabs/tab_unittest.mm

Issue 2845913003: Cleaned up unused methods from WebStateImpl and NavigationContextImpl. (Closed)
Patch Set: Fixed tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/DEPS ('k') | ios/web/public/test/fakes/crw_test_web_state_observer.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_unittest.mm
diff --git a/ios/chrome/browser/tabs/tab_unittest.mm b/ios/chrome/browser/tabs/tab_unittest.mm
index 133db5a2ffd94ed64bfb585896a4f9871126bd7d..76d2518ff4380daec5bef5ff334c2d4a3c9193e8 100644
--- a/ios/chrome/browser/tabs/tab_unittest.mm
+++ b/ios/chrome/browser/tabs/tab_unittest.mm
@@ -47,6 +47,7 @@
#import "ios/web/public/navigation_manager.h"
#include "ios/web/public/referrer.h"
#include "ios/web/public/test/test_web_thread_bundle.h"
+#include "ios/web/web_state/navigation_context_impl.h"
#import "ios/web/web_state/ui/crw_web_controller.h"
#import "ios/web/web_state/web_state_impl.h"
#import "net/base/mac/url_conversions.h"
@@ -244,7 +245,10 @@ class TabTest : public BlockCleanupTest {
web_state_impl_->OnProvisionalNavigationStarted(redirectUrl);
[[tab_ navigationManagerImpl]->GetSessionController() commitPendingItem];
web_state_impl_->UpdateHttpResponseHeaders(redirectUrl);
- web_state_impl_->OnNavigationCommitted(redirectUrl);
+ std::unique_ptr<web::NavigationContext> context =
+ web::NavigationContextImpl::CreateNavigationContext(
+ web_state_impl_.get(), redirectUrl);
+ web_state_impl_->OnNavigationFinished(context.get());
base::string16 new_title = base::SysNSStringToUTF16(title);
[tab_ navigationManager]->GetLastCommittedItem()->SetTitle(new_title);
« no previous file with comments | « ios/chrome/browser/tabs/DEPS ('k') | ios/web/public/test/fakes/crw_test_web_state_observer.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698