Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(152)

Side by Side Diff: ios/web/web_state/web_state_impl.mm

Issue 2845913003: Cleaned up unused methods from WebStateImpl and NavigationContextImpl. (Closed)
Patch Set: Fixed tests Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/web/web_state/web_state_impl.h ('k') | ios/web/web_state/web_state_impl_unittest.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import "ios/web/web_state/web_state_impl.h" 5 #import "ios/web/web_state/web_state_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/logging.h" 10 #include "base/logging.h"
(...skipping 147 matching lines...) Expand 10 before | Expand all | Expand 10 after
158 158
159 CRWWebController* WebStateImpl::GetWebController() { 159 CRWWebController* WebStateImpl::GetWebController() {
160 return web_controller_; 160 return web_controller_;
161 } 161 }
162 162
163 void WebStateImpl::SetWebController(CRWWebController* web_controller) { 163 void WebStateImpl::SetWebController(CRWWebController* web_controller) {
164 [web_controller_ close]; 164 [web_controller_ close];
165 web_controller_.reset([web_controller retain]); 165 web_controller_.reset([web_controller retain]);
166 } 166 }
167 167
168 void WebStateImpl::OnNavigationCommitted(const GURL& url) {
169 std::unique_ptr<NavigationContext> context =
170 NavigationContextImpl::CreateNavigationContext(this, url,
171 GetHttpResponseHeaders());
172 for (auto& observer : observers_)
173 observer.DidFinishNavigation(context.get());
174 }
175
176 void WebStateImpl::OnSameDocumentNavigation(const GURL& url) {
177 std::unique_ptr<NavigationContext> context =
178 NavigationContextImpl::CreateSameDocumentNavigationContext(this, url);
179 for (auto& observer : observers_)
180 observer.DidFinishNavigation(context.get());
181 }
182
183 void WebStateImpl::OnErrorPageNavigation(const GURL& url) {
184 std::unique_ptr<NavigationContext> context =
185 NavigationContextImpl::CreateErrorPageNavigationContext(
186 this, url, GetHttpResponseHeaders());
187 for (auto& observer : observers_)
188 observer.DidFinishNavigation(context.get());
189 }
190
191 void WebStateImpl::OnTitleChanged() { 168 void WebStateImpl::OnTitleChanged() {
192 for (auto& observer : observers_) 169 for (auto& observer : observers_)
193 observer.TitleWasSet(); 170 observer.TitleWasSet();
194 } 171 }
195 172
196 void WebStateImpl::OnVisibleSecurityStateChange() { 173 void WebStateImpl::OnVisibleSecurityStateChange() {
197 for (auto& observer : observers_) 174 for (auto& observer : observers_)
198 observer.DidChangeVisibleSecurityState(); 175 observer.DidChangeVisibleSecurityState();
199 } 176 }
200 177
(...skipping 531 matching lines...) Expand 10 before | Expand all | Expand 10 after
732 const LoadCommittedDetails& load_details) { 709 const LoadCommittedDetails& load_details) {
733 for (auto& observer : observers_) 710 for (auto& observer : observers_)
734 observer.NavigationItemCommitted(load_details); 711 observer.NavigationItemCommitted(load_details);
735 } 712 }
736 713
737 WebState* WebStateImpl::GetWebState() { 714 WebState* WebStateImpl::GetWebState() {
738 return this; 715 return this;
739 } 716 }
740 717
741 } // namespace web 718 } // namespace web
OLDNEW
« no previous file with comments | « ios/web/web_state/web_state_impl.h ('k') | ios/web/web_state/web_state_impl_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698