Move "create a module script" from ModuleScriptLoader to ModuleScript

Move "create a module script" from ModuleScriptLoader to ModuleScript

Because it will be used from outside ModuleScriptLoader when we support
inline scripts.

This CL
- Renames existing ModuleScript::Create() (which is a simple wrapper of
  the constructor) to CreateForTest(),
- Moves ModuleScriptLoader::CreateModuleScript() to new
  ModuleScript::Create(), and
- Reorders the parameters to match with the spec.

BUG=594639, 715369
Review-Url: https://codereview.chromium.org/2845743003
Cr-Commit-Position: refs/heads/master@{#467873}
Committed: https://chromium.googlesource.com/chromium/src/+/498b00e062fb73064e19187b6b174f0d6ff62968

[hiroshige, 2017-04-26 22:14:02]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-26 22:14:29]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-26 22:18:37]

Description was changed from

==========
Move "create a module script" from ModuleScriptLoader to ModuleScript

BUG=
==========

to

==========
Move "create a module script" from ModuleScriptLoader to ModuleScript

Because it will be used from outside ModuleScriptLoader when we support
inline scripts.

This CL
- Renames existing ModuleScript::Create() (which is a simple wrapper of
  the constructor) to CreateForTest(),
- Moves ModuleScriptLoader::CreateModuleScript() to new
  ModuleScript::Create(), and
- Reorders the parameters to match with the spec.

BUG=594639
==========

[hiroshige, 2017-04-26 22:18:37]

hiroshige@chromium.org changed reviewers:
+ kouhei@chromium.org

[hiroshige, 2017-04-26 22:18:53]

PTAL.

[kouhei (in TOK), 2017-04-26 22:36:22]

lgtm. It looks like we can remove ModuleScriptLoader::CreateForTesting in the
future too.

[commit-bot: I haz the power, 2017-04-27 00:06:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 00:06:58]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[hiroshige, 2017-04-27 20:13:51]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 20:14:25]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-27 20:47:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 20:47:24]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[hiroshige, 2017-04-27 21:05:46]

Description was changed from

==========
Move "create a module script" from ModuleScriptLoader to ModuleScript

Because it will be used from outside ModuleScriptLoader when we support
inline scripts.

This CL
- Renames existing ModuleScript::Create() (which is a simple wrapper of
  the constructor) to CreateForTest(),
- Moves ModuleScriptLoader::CreateModuleScript() to new
  ModuleScript::Create(), and
- Reorders the parameters to match with the spec.

BUG=594639
==========

to

==========
Move "create a module script" from ModuleScriptLoader to ModuleScript

Because it will be used from outside ModuleScriptLoader when we support
inline scripts.

This CL
- Renames existing ModuleScript::Create() (which is a simple wrapper of
  the constructor) to CreateForTest(),
- Moves ModuleScriptLoader::CreateModuleScript() to new
  ModuleScript::Create(), and
- Reorders the parameters to match with the spec.

BUG=594639, 715369
==========

[hiroshige, 2017-04-27 21:45:00]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:45:48]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hiroshige, 2017-04-27 21:51:46]

The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 21:52:36]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 01:36:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-28 01:36:49]

Dry run: This issue passed the CQ dry run.

[hiroshige, 2017-04-28 03:25:20]

The CQ bit was checked by hiroshige@chromium.org

[hiroshige, 2017-04-28 03:25:20]

The patchset sent to the CQ was uploaded after l-g-t-m from kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2845743003/#ps60001
(title: "Rebase")

[commit-bot: I haz the power, 2017-04-28 03:25:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 03:34:37]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1493349920009480,
"parent_rev": "27b783e6f88c15406205480a5cf748389b307b8b", "commit_rev":
"498b00e062fb73064e19187b6b174f0d6ff62968"}

[commit-bot: I haz the power, 2017-04-28 03:34:45]

Description was changed from

==========
Move "create a module script" from ModuleScriptLoader to ModuleScript

Because it will be used from outside ModuleScriptLoader when we support
inline scripts.

This CL
- Renames existing ModuleScript::Create() (which is a simple wrapper of
  the constructor) to CreateForTest(),
- Moves ModuleScriptLoader::CreateModuleScript() to new
  ModuleScript::Create(), and
- Reorders the parameters to match with the spec.

BUG=594639, 715369
==========

to

==========
Move "create a module script" from ModuleScriptLoader to ModuleScript

Because it will be used from outside ModuleScriptLoader when we support
inline scripts.

This CL
- Renames existing ModuleScript::Create() (which is a simple wrapper of
  the constructor) to CreateForTest(),
- Moves ModuleScriptLoader::CreateModuleScript() to new
  ModuleScript::Create(), and
- Reorders the parameters to match with the spec.

BUG=594639, 715369

Review-Url: https://codereview.chromium.org/2845743003
Cr-Commit-Position: refs/heads/master@{#467873}
Committed:
https://chromium.googlesource.com/chromium/src/+/498b00e062fb73064e19187b6b17...
==========

[commit-bot: I haz the power, 2017-04-28 03:34:45]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/498b00e062fb73064e19187b6b17...