Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 2844413003: Introduce ModuleScript::CreateInternal() (Closed)

Created:
3 years, 7 months ago by hiroshige
Modified:
3 years, 7 months ago
Reviewers:
kouhei (in TOK)
CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Introduce ModuleScript::CreateInternal() This is preparation for https://codereview.chromium.org/2850673002 to create a place to insert RegisterModuleScript() both for Create() and CreateForTest(). This doesn't change the behavior. BUG=594639, 715369 Review-Url: https://codereview.chromium.org/2844413003 Cr-Commit-Position: refs/heads/master@{#467891} Committed: https://chromium.googlesource.com/chromium/src/+/d97cc73459881aeedfb39ed40ff5e0f9aefea9aa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -10 lines) Patch
M third_party/WebKit/Source/core/dom/ModuleScript.h View 2 chunks +16 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ModuleScript.cpp View 3 chunks +25 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
hiroshige
PTAL.
3 years, 7 months ago (2017-04-28 01:09:16 UTC) #4
kouhei (in TOK)
lgtm
3 years, 7 months ago (2017-04-28 01:11:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2844413003/1
3 years, 7 months ago (2017-04-28 04:14:56 UTC) #10
commit-bot: I haz the power
3 years, 7 months ago (2017-04-28 05:18:14 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/d97cc73459881aeedfb39ed40ff5...

Powered by Google App Engine
This is Rietveld 408576698