Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1049)

Unified Diff: third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp

Issue 2845743003: Move "create a module script" from ModuleScriptLoader to ModuleScript (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp
diff --git a/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp b/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp
index 80d66873e4f614dbaab0858657cfb354eea134d0..845e532dc8f83cbc7e3b40bc658bb24592c69908 100644
--- a/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp
+++ b/third_party/WebKit/Source/core/loader/modulescript/ModuleTreeLinkerTest.cpp
@@ -76,9 +76,9 @@ class ModuleTreeLinkerTestModulator final : public DummyModulator {
ScriptModule script_module = ScriptModule::Compile(
script_state_->GetIsolate(), source_text.ToString(), url.GetString(),
kSharableCrossOrigin);
- ModuleScript* module_script =
- ModuleScript::Create(this, script_module, url, "", kParserInserted,
- WebURLRequest::kFetchCredentialsModeOmit);
+ ModuleScript* module_script = ModuleScript::CreateForTest(
+ this, script_module, url, "", kParserInserted,
+ WebURLRequest::kFetchCredentialsModeOmit);
auto result_request = dependency_module_requests_map_.insert(
script_module, dependency_module_requests);
EXPECT_TRUE(result_request.is_new_entry);
@@ -121,9 +121,9 @@ class ModuleTreeLinkerTestModulator final : public DummyModulator {
ScriptModule script_module = ScriptModule::Compile(
script_state_->GetIsolate(), "export default 'pineapples';",
url.GetString(), kSharableCrossOrigin);
- ModuleScript* module_script =
- ModuleScript::Create(this, script_module, url, "", kParserInserted,
- WebURLRequest::kFetchCredentialsModeOmit);
+ ModuleScript* module_script = ModuleScript::CreateForTest(
+ this, script_module, url, "", kParserInserted,
+ WebURLRequest::kFetchCredentialsModeOmit);
auto result_map = module_map_.insert(url, module_script);
EXPECT_TRUE(result_map.is_new_entry);
« no previous file with comments | « third_party/WebKit/Source/core/loader/modulescript/ModuleScriptLoader.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698