Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: third_party/WebKit/Source/core/dom/ModuleScript.h

Issue 2845743003: Move "create a module script" from ModuleScriptLoader to ModuleScript (Closed)
Patch Set: Rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/ModuleScript.h
diff --git a/third_party/WebKit/Source/core/dom/ModuleScript.h b/third_party/WebKit/Source/core/dom/ModuleScript.h
index df85c45c370b07b1eae561bbffb1b69a249b3abe..5ac8f9fff98fe2ab20909e10c2c2a5d643e68d7f 100644
--- a/third_party/WebKit/Source/core/dom/ModuleScript.h
+++ b/third_party/WebKit/Source/core/dom/ModuleScript.h
@@ -30,7 +30,16 @@ enum class ModuleInstantiationState {
// https://html.spec.whatwg.org/multipage/webappapis.html#module-script
class CORE_EXPORT ModuleScript final : public Script, public TraceWrapperBase {
public:
- static ModuleScript* Create(
+ // https://html.spec.whatwg.org/#creating-a-module-script
+ static ModuleScript* Create(const String& source_text,
+ Modulator*,
+ const KURL& base_url,
+ const String& nonce,
+ ParserDisposition,
+ WebURLRequest::FetchCredentialsMode,
+ AccessControlStatus);
+
+ static ModuleScript* CreateForTest(
Modulator* settings_object,
ScriptModule record,
const KURL& base_url,
« no previous file with comments | « third_party/WebKit/Source/core/dom/ModuleMapTest.cpp ('k') | third_party/WebKit/Source/core/dom/ModuleScript.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698