Add UMA histogram to track the various sources that request the feedback app

Add UMA histogram to track the various sources that request the feedback app

Basically, it is desired to see how many feedbacks are filed from the sad
tab page relative to other sources.

BUG=715682
Review-Url: https://codereview.chromium.org/2844193002
Cr-Commit-Position: refs/heads/master@{#467850}
Committed: https://chromium.googlesource.com/chromium/src/+/f4575bd1aaaefd72960d870baca58387ab9b9e95

[afakhry, 2017-04-27 02:36:11]

The CQ bit was checked by afakhry@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-27 02:36:54]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[afakhry, 2017-04-27 02:52:17]

afakhry@chromium.org changed reviewers:
+ mpearson@chromium.org, thestig@chromium.org

[afakhry, 2017-04-27 02:52:17]

thestig for chrome, mpearson for histograms.

[commit-bot: I haz the power, 2017-04-27 05:00:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-27 05:00:46]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Mark P, 2017-04-27 21:10:12]

histograms.xml lgtm

[Lei Zhang, 2017-04-27 21:25:07]

lgtm

https://codereview.chromium.org/2844193002/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/supervised_user_interstitial.cc (right):

https://codereview.chromium.org/2844193002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_interstitial.cc:275: message, ""
/* category_tag */);
Leave the std::string()s alone. Since ShowFeedbackPage() takes a std::string()
by const-ref, pass in a std::string to avoid the implicit construction.
Apparently that causes the compiler to generate a lot of code.

Ditto elsewhere.

[afakhry, 2017-04-27 21:39:54]

https://codereview.chromium.org/2844193002/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/supervised_user_interstitial.cc (right):

https://codereview.chromium.org/2844193002/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_interstitial.cc:275: message, ""
/* category_tag */);
On 2017/04/27 21:25:07, Lei Zhang wrote:
> Leave the std::string()s alone. Since ShowFeedbackPage() takes a std::string()
> by const-ref, pass in a std::string to avoid the implicit construction.
> Apparently that causes the compiler to generate a lot of code.
> 
> Ditto elsewhere.

Done.

[afakhry, 2017-04-27 21:40:06]

The CQ bit was checked by afakhry@chromium.org

[afakhry, 2017-04-27 21:40:07]

The patchset sent to the CQ was uploaded after l-g-t-m from
thestig@chromium.org, mpearson@chromium.org
Link to the patchset: https://codereview.chromium.org/2844193002/#ps20001
(title: """ --> string()")

[commit-bot: I haz the power, 2017-04-27 21:40:45]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-28 02:21:13]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1493329206640690,
"parent_rev": "e47fb498dce50d65d9c3b55fafdbffbe50ab6920", "commit_rev":
"f4575bd1aaaefd72960d870baca58387ab9b9e95"}

[commit-bot: I haz the power, 2017-04-28 02:21:21]

Description was changed from

==========
Add UMA histogram to track the various sources that request the feedback app

Basically, it is desired to see how many feedbacks are filed from the sad
tab page relative to other sources.

BUG=715682
==========

to

==========
Add UMA histogram to track the various sources that request the feedback app

Basically, it is desired to see how many feedbacks are filed from the sad
tab page relative to other sources.

BUG=715682

Review-Url: https://codereview.chromium.org/2844193002
Cr-Commit-Position: refs/heads/master@{#467850}
Committed:
https://chromium.googlesource.com/chromium/src/+/f4575bd1aaaefd72960d870baca5...
==========

[commit-bot: I haz the power, 2017-04-28 02:21:22]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/f4575bd1aaaefd72960d870baca5...