Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3302)

Unified Diff: chrome/browser/ui/chrome_pages.h

Issue 2844193002: Add UMA histogram to track the various sources that request the feedback app (Closed)
Patch Set: "" --> string() Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/profile_error_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/chrome_pages.h
diff --git a/chrome/browser/ui/chrome_pages.h b/chrome/browser/ui/chrome_pages.h
index 98513ebaaaea65e3c83c87e79c9d8e2ab8539639..61f08afc391167aca874c687252c6f5748c61a92 100644
--- a/chrome/browser/ui/chrome_pages.h
+++ b/chrome/browser/ui/chrome_pages.h
@@ -34,6 +34,24 @@ enum HelpSource {
HELP_SOURCE_WEBUI,
};
+// Sources of feedback requests.
+//
+// WARNING: The below enum MUST never be renamed, modified or reordered, as
+// they're written to logs. You can only insert a new element immediately
+// before the last.
+enum FeedbackSource {
+ kFeedbackSourceArcApp = 0,
+ kFeedbackSourceAsh,
+ kFeedbackSourceBrowserCommand,
+ kFeedbackSourceMdSettingsAboutPage,
+ kFeedbackSourceOldSettingsAboutPage,
+ kFeedbackSourceProfileErrorDialog,
+ kFeedbackSourceSadTabPage,
+ kFeedbackSourceSupervisedUserInterstitial,
+
+ // Must be last.
+ kFeedbackSourceCount,
+};
void ShowBookmarkManager(Browser* browser);
void ShowBookmarkManagerForNode(Browser* browser, int64_t node_id);
@@ -46,6 +64,7 @@ void ShowConflicts(Browser* browser);
// ShowFeedbackPage() uses |browser| to determine the URL of the current tab.
// |browser| should be NULL if there are no currently open browser windows.
void ShowFeedbackPage(Browser* browser,
+ FeedbackSource source,
const std::string& description_template,
const std::string& category_tag);
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/profile_error_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698