Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(945)

Side by Side Diff: chrome/browser/ui/chrome_pages.h

Issue 2844193002: Add UMA histogram to track the various sources that request the feedback app (Closed)
Patch Set: "" --> string() Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/profile_error_dialog.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_CHROME_PAGES_H_ 5 #ifndef CHROME_BROWSER_UI_CHROME_PAGES_H_
6 #define CHROME_BROWSER_UI_CHROME_PAGES_H_ 6 #define CHROME_BROWSER_UI_CHROME_PAGES_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <string> 10 #include <string>
(...skipping 16 matching lines...) Expand all
27 // Keyboard accelerators. 27 // Keyboard accelerators.
28 HELP_SOURCE_KEYBOARD, 28 HELP_SOURCE_KEYBOARD,
29 29
30 // Menus (e.g. app menu or Chrome OS system menu). 30 // Menus (e.g. app menu or Chrome OS system menu).
31 HELP_SOURCE_MENU, 31 HELP_SOURCE_MENU,
32 32
33 // WebUI (the "About" page). 33 // WebUI (the "About" page).
34 HELP_SOURCE_WEBUI, 34 HELP_SOURCE_WEBUI,
35 }; 35 };
36 36
37 // Sources of feedback requests.
38 //
39 // WARNING: The below enum MUST never be renamed, modified or reordered, as
40 // they're written to logs. You can only insert a new element immediately
41 // before the last.
42 enum FeedbackSource {
43 kFeedbackSourceArcApp = 0,
44 kFeedbackSourceAsh,
45 kFeedbackSourceBrowserCommand,
46 kFeedbackSourceMdSettingsAboutPage,
47 kFeedbackSourceOldSettingsAboutPage,
48 kFeedbackSourceProfileErrorDialog,
49 kFeedbackSourceSadTabPage,
50 kFeedbackSourceSupervisedUserInterstitial,
51
52 // Must be last.
53 kFeedbackSourceCount,
54 };
37 55
38 void ShowBookmarkManager(Browser* browser); 56 void ShowBookmarkManager(Browser* browser);
39 void ShowBookmarkManagerForNode(Browser* browser, int64_t node_id); 57 void ShowBookmarkManagerForNode(Browser* browser, int64_t node_id);
40 void ShowHistory(Browser* browser); 58 void ShowHistory(Browser* browser);
41 void ShowDownloads(Browser* browser); 59 void ShowDownloads(Browser* browser);
42 void ShowExtensions(Browser* browser, 60 void ShowExtensions(Browser* browser,
43 const std::string& extension_to_highlight); 61 const std::string& extension_to_highlight);
44 void ShowConflicts(Browser* browser); 62 void ShowConflicts(Browser* browser);
45 63
46 // ShowFeedbackPage() uses |browser| to determine the URL of the current tab. 64 // ShowFeedbackPage() uses |browser| to determine the URL of the current tab.
47 // |browser| should be NULL if there are no currently open browser windows. 65 // |browser| should be NULL if there are no currently open browser windows.
48 void ShowFeedbackPage(Browser* browser, 66 void ShowFeedbackPage(Browser* browser,
67 FeedbackSource source,
49 const std::string& description_template, 68 const std::string& description_template,
50 const std::string& category_tag); 69 const std::string& category_tag);
51 70
52 void ShowHelp(Browser* browser, HelpSource source); 71 void ShowHelp(Browser* browser, HelpSource source);
53 void ShowHelpForProfile(Profile* profile, HelpSource source); 72 void ShowHelpForProfile(Profile* profile, HelpSource source);
54 void ShowPolicy(Browser* browser); 73 void ShowPolicy(Browser* browser);
55 void ShowSlow(Browser* browser); 74 void ShowSlow(Browser* browser);
56 75
57 // Constructs a settings GURL for the specified |sub_page|. 76 // Constructs a settings GURL for the specified |sub_page|.
58 GURL GetSettingsUrl(const std::string& sub_page); 77 GURL GetSettingsUrl(const std::string& sub_page);
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
93 112
94 // If the user is already signed in, shows the "Signin" portion of Settings, 113 // If the user is already signed in, shows the "Signin" portion of Settings,
95 // otherwise initiates signin in a new browser tab. 114 // otherwise initiates signin in a new browser tab.
96 void ShowBrowserSigninOrSettings(Browser* browser, 115 void ShowBrowserSigninOrSettings(Browser* browser,
97 signin_metrics::AccessPoint access_point); 116 signin_metrics::AccessPoint access_point);
98 #endif 117 #endif
99 118
100 } // namespace chrome 119 } // namespace chrome
101 120
102 #endif // CHROME_BROWSER_UI_CHROME_PAGES_H_ 121 #endif // CHROME_BROWSER_UI_CHROME_PAGES_H_
OLDNEW
« no previous file with comments | « chrome/browser/ui/browser_commands.cc ('k') | chrome/browser/ui/profile_error_dialog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698