Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Side by Side Diff: chrome/browser/chromeos/arc/arc_session_manager.cc

Issue 2844193002: Add UMA histogram to track the various sources that request the feedback app (Closed)
Patch Set: "" --> string() Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/feedback/show_feedback_page.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/arc/arc_session_manager.h" 5 #include "chrome/browser/chromeos/arc/arc_session_manager.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
(...skipping 986 matching lines...) Expand 10 before | Expand all | Expand 10 after
997 } else { 997 } else {
998 // Otherwise, we restart ARC. Note: this is the first boot case. 998 // Otherwise, we restart ARC. Note: this is the first boot case.
999 // For second or later boot, either ERROR_WITH_FEEDBACK case or ACTIVE 999 // For second or later boot, either ERROR_WITH_FEEDBACK case or ACTIVE
1000 // case must hit. 1000 // case must hit.
1001 StartAndroidManagementCheck(); 1001 StartAndroidManagementCheck();
1002 } 1002 }
1003 } 1003 }
1004 1004
1005 void ArcSessionManager::OnSendFeedbackClicked() { 1005 void ArcSessionManager::OnSendFeedbackClicked() {
1006 DCHECK(support_host_); 1006 DCHECK(support_host_);
1007 chrome::OpenFeedbackDialog(nullptr); 1007 chrome::OpenFeedbackDialog(nullptr, chrome::kFeedbackSourceArcApp);
1008 } 1008 }
1009 1009
1010 void ArcSessionManager::SetArcSessionRunnerForTesting( 1010 void ArcSessionManager::SetArcSessionRunnerForTesting(
1011 std::unique_ptr<ArcSessionRunner> arc_session_runner) { 1011 std::unique_ptr<ArcSessionRunner> arc_session_runner) {
1012 DCHECK(arc_session_runner); 1012 DCHECK(arc_session_runner);
1013 DCHECK(arc_session_runner_); 1013 DCHECK(arc_session_runner_);
1014 DCHECK(arc_session_runner_->IsStopped()); 1014 DCHECK(arc_session_runner_->IsStopped());
1015 arc_session_runner_->RemoveObserver(this); 1015 arc_session_runner_->RemoveObserver(this);
1016 arc_session_runner_ = std::move(arc_session_runner); 1016 arc_session_runner_ = std::move(arc_session_runner);
1017 arc_session_runner_->AddObserver(this); 1017 arc_session_runner_->AddObserver(this);
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
1049 1049
1050 #undef MAP_STATE 1050 #undef MAP_STATE
1051 1051
1052 // Some compilers report an error even if all values of an enum-class are 1052 // Some compilers report an error even if all values of an enum-class are
1053 // covered exhaustively in a switch statement. 1053 // covered exhaustively in a switch statement.
1054 NOTREACHED() << "Invalid value " << static_cast<int>(state); 1054 NOTREACHED() << "Invalid value " << static_cast<int>(state);
1055 return os; 1055 return os;
1056 } 1056 }
1057 1057
1058 } // namespace arc 1058 } // namespace arc
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/feedback/show_feedback_page.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698